feature - implement RFC 023 approximate count distinct (#40)#50
Draft
dannymeijer wants to merge 1 commit into
Draft
feature - implement RFC 023 approximate count distinct (#40)#50dannymeijer wants to merge 1 commit into
dannymeijer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approx_count_distinct(...)Verification
make fmtincan test tests/test_approximate_functions.incnincan test tests/test_function_registry.incnincan test tests/test_substrait_plan.incnincan test tests/test_prism.incnincan test tests/test_session_aggregates.incnmake fmt-checkmake test-stylemake registry-metadatamake buildmake testmake smoke-consumermake pre-commitStack / Merge Order
This PR is stacked after #49 and should merge only after:
#44 -> #45 -> #46 -> #47 -> #48 -> #49 -> this PR
Refs #40