Desktop app UI #24

dannysmith · 2026-01-10T03:35:59Z

Summary by CodeRabbit

New Features
- Vault integration: browse, read, create, update, delete tasks/projects/areas; deep linking (taskdn://)
- Month & Week calendar views with drag‑and‑drop; Area Kanban with per‑project swimlanes
UI
- New Task/Project/Area cards, Markdown editor & rich preview, date picker button, collapsible notes, view header, progress circle, updated titlebar
Preferences
- Ignore patterns, Obsidian features toggle, permanent‑delete option
Chores
- Expanded localization keys and window/quick‑pane sizing adjustments

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…cumentation

coderabbitai

Actionable comments posted: 3

🤖 Fix all issues with AI agents

In `@tdn-desktop/src/App.css`:
- Around line 275-283: The checkmark SVG in .milkdown-editor
.milkdown-list-item-block .label.checked::after hardcodes stroke='white', which
can be invisible on light primary colors; update the rule to make the checkmark
color theme-aware by either using currentColor in the embedded SVG (e.g.,
stroke='currentColor') and setting color on .label.checked to a suitable theme
variable (like --primary-foreground) or by switching to an inline SVG mask/PNG
with background-color driven by a CSS variable or applying a CSS filter that
maps white to a theme variable; change the SVG stroke and ensure the element
sets the corresponding CSS variable (e.g., color or --checkmark-color) so
contrast follows the active theme.

In `@tdn-desktop/src/components/cards/TaskCard.tsx`:
- Around line 287-289: The placeholder string in the TaskCard component is
hardcoded and must be internationalized: import useTranslation from
'react-i18next', call const { t } = useTranslation() inside the TaskCard
component, then replace the literal placeholder on the textarea/input (the
element with className "... placeholder=\"Task title...\"") with a t(...) call
using a new translation key (e.g. 'task.titlePlaceholder' or similar) so the
user-facing string comes from i18n.
- Around line 314-333: Replace the hardcoded "Scheduled" and "Due" label props
on the DatePickerButton components with translated strings: import and use the
useTranslation hook (e.g., const { t } = useTranslation()) and pass
t('task.scheduled') and t('task.due') (or similar keys) to the label prop for
the DatePickerButton instances (references: DatePickerButton,
handleScheduledSelect, handleDueSelect, onScheduledChange, onDueChange). Add the
corresponding keys to the locales JSON files under /locales/*.json (e.g.,
"task": { "scheduled": "...", "due": "..." }) and ensure tests/type checks pick
up the new keys.

♻️ Duplicate comments (2)

tdn-desktop/src/components/cards/TaskCard.tsx (1)

198-200: Date parsing timezone issue previously flagged.

The timezone concern with new Date(task.scheduled) parsing YYYY-MM-DD as UTC has already been raised in a prior review. Please address that feedback.
tdn-desktop/locales/en.json (1)
208-209: Missing .label key for revealInFinder command.

Other commands include .label, .description, and .success/.error keys. The revealInFinder command is missing its .label key for consistency.
Suggested fix
+  "commands.revealInFinder.label": "Reveal in File Manager",
   "commands.revealInFinder.description": "Show the file in the system file manager",
   "commands.revealInFinder.error": "Failed to reveal file",

🧹 Nitpick comments (3)

tdn-desktop/src/components/cards/TaskCard.tsx (1)
211-246: Compact variant lacks keyboard accessibility.

The compact card has cursor-pointer but no tabIndex or onKeyDown handler, making it inaccessible via keyboard navigation unlike the default variant.
♻️ Suggested fix
       <div
         onClick={onEditClick}
         onContextMenu={handleContextMenu}
+        onKeyDown={(e) => e.key === 'Enter' && onEditClick?.()}
+        tabIndex={0}
+        role="button"
         className={cn(
           'group flex items-center gap-2 rounded-lg border px-2 py-1.5 transition-all cursor-pointer',
           'hover:shadow-sm hover:shadow-black/5',
+          'focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2',
tdn-desktop/src-tauri/tauri.conf.json (1)

16-19: Default window size may exceed some displays.

The new default size of 1800×1200 is larger than many laptop screens (e.g., 1366×768 or 1440×900). While the minimum size (1000×700) is reasonable and window-state plugin will restore user preferences, the initial experience on smaller displays may have the window extending off-screen.

Consider reducing the default to something more universally compatible (e.g., 1280×800) or relying on maximized: true for larger initial coverage.

tdn-desktop/locales/en.json (1)

49-87: Consider consolidating duplicate preference keys.

Several keys are duplicated between preferences.general.* and preferences.vault.* namespaces (e.g., tasksDir, tasksDirDescription, choose, notConfigured). If these render identical text, consider using a shared namespace (e.g., preferences.shared.*) to reduce maintenance burden and ensure consistency.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d10e54 and 3bc360c.

⛔ Files ignored due to path filters (13)

tdn-desktop/bun.lock is excluded by !**/*.lock
tdn-desktop/docs/developer/deep-linking.md is excluded by !**/*.md
tdn-desktop/docs/tasks-done/task-2026-01-13-2-url-scheme.md is excluded by !**/*.md
tdn-desktop/docs/tasks-done/task-2026-01-14-4-phase1-findings.md is excluded by !**/*.md
tdn-desktop/docs/tasks-done/task-2026-01-14-4-ui-component-review.md is excluded by !**/*.md
tdn-desktop/docs/tasks-done/task-2026-01-14-5-datepicker.md is excluded by !**/*.md
tdn-desktop/docs/tasks-done/task-2026-01-14-6-quick-search.md is excluded by !**/*.md
tdn-desktop/docs/tasks-done/task-2026-01-14-7-navigation-history.md is excluded by !**/*.md
tdn-desktop/docs/tasks-todo/task-10-publishing.md is excluded by !**/*.md
tdn-desktop/docs/tasks-todo/task-8-quick-capture-pane.md is excluded by !**/*.md
tdn-desktop/docs/tasks-todo/task-9-reviews.md is excluded by !**/*.md
tdn-desktop/docs/tasks-todo/task-x-undo.md is excluded by !**/*.md
tdn-desktop/src/components/ui/README.md is excluded by !**/*.md

📒 Files selected for processing (44)

tdn-desktop/knip.json
tdn-desktop/locales/en.json
tdn-desktop/package.json
tdn-desktop/src-tauri/capabilities/desktop.json
tdn-desktop/src-tauri/src/lib.rs
tdn-desktop/src-tauri/tauri.conf.json
tdn-desktop/src/App.css
tdn-desktop/src/components/cards/TaskCard.tsx
tdn-desktop/src/components/layout/LeftSideBar.tsx
tdn-desktop/src/components/layout/MainWindow.tsx
tdn-desktop/src/components/preferences/PreferencesDialog.tsx
tdn-desktop/src/components/preferences/panes/AdvancedPane.tsx
tdn-desktop/src/components/preferences/panes/AppearancePane.tsx
tdn-desktop/src/components/preferences/panes/GeneralPane.tsx
tdn-desktop/src/components/preferences/panes/QuickEntryPane.tsx
tdn-desktop/src/components/preferences/panes/VaultPane.tsx
tdn-desktop/src/components/preferences/shared/SettingsComponents.tsx
tdn-desktop/src/components/quick-search/QuickSearch.tsx
tdn-desktop/src/components/quick-search/QuickSearchResult.tsx
tdn-desktop/src/components/quick-search/utils.ts
tdn-desktop/src/components/sidebar/AppSidebar.tsx
tdn-desktop/src/components/ui/calendar.tsx
tdn-desktop/src/components/ui/date-button.tsx
tdn-desktop/src/components/ui/date-picker.tsx
tdn-desktop/src/components/ui/popover-date-picker.tsx
tdn-desktop/src/components/views/AreaView.tsx
tdn-desktop/src/components/views/ComponentReference.tsx
tdn-desktop/src/components/views/NoAreaView.tsx
tdn-desktop/src/components/views/WeekView.tsx
tdn-desktop/src/hooks/use-command-context.ts
tdn-desktop/src/hooks/use-deep-link.ts
tdn-desktop/src/lib/commands/app-commands.ts
tdn-desktop/src/lib/commands/commands.test.ts
tdn-desktop/src/lib/commands/navigation-commands.ts
tdn-desktop/src/lib/commands/types.ts
tdn-desktop/src/lib/deep-link.test.ts
tdn-desktop/src/lib/deep-link.ts
tdn-desktop/src/lib/task-navigation.test.ts
tdn-desktop/src/lib/task-navigation.ts
tdn-desktop/src/main.tsx
tdn-desktop/src/store/navigation-store.test.ts
tdn-desktop/src/store/navigation-store.ts
tdn-desktop/src/store/task-detail-store.ts
tdn-desktop/src/store/ui-store.ts

💤 Files with no reviewable changes (1)

tdn-desktop/knip.json

🚧 Files skipped from review as they are similar to previous changes (2)

tdn-desktop/package.json
tdn-desktop/src-tauri/capabilities/desktop.json

🧰 Additional context used

📓 Path-based instructions (5)

tdn-desktop/**/*.{tsx,css,scss}