-
Notifications
You must be signed in to change notification settings - Fork 10
Description
Context
When Freshell launches a Codex session, it injects orchestration skills via -c skills.config=[...]. This replaces the entire skills.config array, so any user-defined Codex skills in ~/.codex/config.toml are silently dropped.
The previous implementation (pre-#89) attempted additivity using high-index dotted keys (skills.config.400000.path=...), but that approach never worked — Codex's TOML parser rejects dotted keys on array fields, causing every Codex session to crash with Error loading config.toml: invalid type: map, expected a sequence.
Expected behavior
Freshell-injected skills should be merged with the user's existing skills.config entries, not replace them.
Suggested approach
- Read
~/.codex/config.tomlat spawn time - Parse existing
skills.configentries (requires adding a TOML parser likesmol-toml) - Merge Freshell entries with user entries
- Emit the combined array via
-c skills.config=[...]
Impact
Only affects users who maintain custom Codex skills in their config.toml. Currently low impact since Codex skill injection was completely broken before #89.