Skip to content

Bug Fixes #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Bug Fixes #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0625a1b
fix unassigned parameters
dansiegel Dec 11, 2020
f901699
fix equality check for duplicate parameters
dansiegel Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CodeGenHelpers/ParameterizedExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public static T AddParameters<T>(this IParameterized<T> parameterized, IEnumerab
private static T AddParameterInternal<T>(this IParameterized<T> parameterized, ParameterBuilder<T> parameter, int index)
where T : BuilderBase<T>, IParameterized<T>
{
if (parameterized.Parameters.Any(p => p == parameter))
if (parameterized.Parameters.Any(p => p.Type == parameter.Type && p.Name == parameter.Name))
return parameterized.Parent;

if (index > -1)
Expand Down
2 changes: 2 additions & 0 deletions src/CodeGenHelpers/SwitchBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ public sealed class SwitchBuilder
internal SwitchBuilder(ICodeWriter writer, string switchOn, bool expression)
{
_writer = writer;
_switchOn = switchOn;
Expression = expression;
}

public SwitchCaseBuilder AddCase(string @case)
Expand Down