Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces comprehensive health check functionality to the EKS nodegroup management tool, providing pre-flight validation using default AWS metrics before AMI updates. The release updates the tool to v0.1.8 with enhanced safety features and improved user experience.
- Implements a full health check system using AWS default metrics (no additional setup required)
- Adds real-time health monitoring with professional UI including spinners and progress bars
- Enhances error handling with user-friendly AWS credential and configuration guidance
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/ui/health.go | New health check UI components with progress bars and color-coded status displays |
| internal/monitoring/display.go | Fixes output duplication by clearing previous progress display before showing completion summary |
| internal/health/workloads.go | Implements Kubernetes workload validation using client-go for critical system pods |
| internal/health/pdbs.go | Validates Pod Disruption Budget coverage for user deployments across namespaces |
| internal/health/nodes.go | Checks EKS nodegroup health status using AWS APIs for blocking validation |
| internal/health/checker.go | Core health check orchestration with decision logic and result aggregation |
| internal/health/capacity.go | Cluster capacity validation using default EC2 CPU metrics with Auto Scaling integration |
| internal/health/balance.go | Resource distribution analysis across nodes using EC2 instance metrics |
| internal/commands/version.go | Version bump from v0.1.7 to v0.1.8 |
| internal/commands/update.go | Integrates health checks into update workflow with new CLI flags and AWS credential validation |
| internal/commands/list.go | Adds AWS credential validation to list command |
| internal/aws/errors.go | New comprehensive AWS error handling with user-friendly messages and setup guidance |
| internal/aws/cluster.go | Improves error formatting by using new AWS error handling functions |
| ideas.md | New feature roadmap document outlining potential enhancements |
| go.mod | Updates Go version to 1.24.0 and dependency versions including Kubernetes client libraries |
| Taskfile.yml | Automates version extraction from version.go file |
| README.md | Comprehensive documentation updates with health check examples and usage patterns |
| CHANGELOG.md | New changelog documenting all changes and improvements in v0.1.8 |
| .goreleaser.yml | Fixes build configuration to properly inject version information |
| .github/workflows/release.yml | Updates Go version to 1.24 for releases |
| .github/workflows/auto-release.yml | New automated release workflow triggered by version changes |
Comments suppressed due to low confidence (4)
go.mod:3
- Go version 1.24.0 does not exist. The latest stable Go version as of January 2025 is 1.23.x. Update to a valid Go version like 1.23.6.
go 1.24.0
go.mod:5
- Go toolchain version 1.24.5 does not exist. Update to a valid Go toolchain version that matches the available Go releases.
toolchain go1.24.5
.github/workflows/release.yml:27
- Go version 1.24 does not exist. Update to a valid Go version like "1.23" to match available releases.
go-version: "1.24"
.github/workflows/auto-release.yml:65
- Go version 1.24 does not exist. Update to a valid Go version like "1.23" to match available releases.
go-version: "1.24"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[0.1.8] - 2025-08-05
Added
Fixed
Enhanced
-c,-n,-d,-f, etc.)Technical Improvements