Skip to content

Feature revision/b aprobar entregable#408

Merged
kcerni merged 6 commits intodevelopfrom
feature-revision/b-aprobar-entregable
Jun 5, 2025
Merged

Feature revision/b aprobar entregable#408
kcerni merged 6 commits intodevelopfrom
feature-revision/b-aprobar-entregable

Conversation

@RGRidge
Copy link
Copy Markdown
Collaborator

@RGRidge RGRidge commented Jun 5, 2025

No description provided.

@aws-amplify-us-east-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-408.de1ybevj6dpja.amplifyapp.com

Copy link
Copy Markdown
Owner

@daoch daoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

kcerni
kcerni previously approved these changes Jun 5, 2025
@kcerni kcerni dismissed their stale review June 5, 2025 16:11

Conflicto

Copy link
Copy Markdown
Owner

@daoch daoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Copy Markdown
Owner

@daoch daoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolver conflicto

@calg03
Copy link
Copy Markdown
Collaborator

calg03 commented Jun 5, 2025

corregir conflictos con develop

@daoch daoch self-requested a review June 5, 2025 19:28
daoch
daoch previously requested changes Jun 5, 2025
Copy link
Copy Markdown
Owner

@daoch daoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgta-frontend:build: ./features/revision/views/RevisionDocumentoPage.tsx:76:6

                             sgta-frontend:build: Type error: Argument of type '{ id: string; titulo: string; estudiante: string; codigo: string; curso: string; entregable: string; fechaEntrega: string; fechaLimite: string; estado: string; porcentajePlagio: number; formatoValido: boolean; entregaATiempo: boolean; citadoCorrecto: boolean; observaciones: never[]; }' is not assignable to parameter of type '{ id: number; titulo: string; estudiante: string; codigo: string; curso: string; entregable: string; fechaEntrega: string; fechaLimite: string; estado: string; porcentajePlagio: number; formatoValido: boolean; entregaATiempo: boolean; citadoCorrecto: boolean; observaciones: Observacion[]; } | (() => { ...; })'.

                             sgta-frontend:build:   Type '{ id: string; titulo: string; estudiante: string; codigo: string; curso: string; entregable: string; fechaEntrega: string; fechaLimite: string; estado: string; porcentajePlagio: number; formatoValido: boolean; entregaATiempo: boolean; citadoCorrecto: boolean; observaciones: never[]; }' is not assignable to type '{ id: number; titulo: string; estudiante: string; codigo: string; curso: string; entregable: string; fechaEntrega: string; fechaLimite: string; estado: string; porcentajePlagio: number; formatoValido: boolean; entregaATiempo: boolean; citadoCorrecto: boolean; observaciones: Observacion[]; }'.

                             sgta-frontend:build:     Types of property 'id' are incompatible.
                             sgta-frontend:build:       Type 'string' is not assignable to type 'number'.

@daoch daoch dismissed their stale review June 5, 2025 20:27

gracias

@kcerni kcerni merged commit 6425a9a into develop Jun 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants