Skip to content

Comments

DAOS-12038 dfs: add file_oclass option for DFS container creation#10786

Merged
jolivier23 merged 1 commit intomasterfrom
mschaara/dfs_foclass
Nov 10, 2022
Merged

DAOS-12038 dfs: add file_oclass option for DFS container creation#10786
jolivier23 merged 1 commit intomasterfrom
mschaara/dfs_foclass

Conversation

@mchaarawi
Copy link
Contributor

@mchaarawi mchaarawi commented Nov 7, 2022 •
edited
Loading

Change oclass to be the default for all objects, and add a new option for file_oclass (dir_oclass is already there).

Features: dfs
Required-githooks: true

Signed-off-by: Mohamad Chaarawi mohamad.chaarawi@intel.com

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficent testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daosbuild1
Copy link
Collaborator

daosbuild1 commented Nov 7, 2022

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10786/1/execution/node/119/log

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Bug-tracker data:
Ticket title is 'Add --file_oclass option for posix containers'
Status is 'Open'
Labels: 'triaged'
Job should run at elevated priority (3)
https://daosio.atlassian.net/browse/DAOS-12038

@github-actions github-actions bot added priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4 labels Nov 7, 2022
@mchaarawi mchaarawi force-pushed the mschaara/dfs_foclass branch from 5891356 to ea2f3c4 Compare November 7, 2022 16:07
@daosbuild1
Copy link
Collaborator

daosbuild1 commented Nov 7, 2022

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10786/2/execution/node/145/log

@mchaarawi mchaarawi force-pushed the mschaara/dfs_foclass branch from ea2f3c4 to ff0452b Compare November 7, 2022 16:21
@daosbuild1
Copy link
Collaborator

daosbuild1 commented Nov 7, 2022

Test stage NLT on EL 8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-10786/2/display/redirect

@daosbuild1
Copy link
Collaborator

daosbuild1 commented Nov 7, 2022

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10786/3/execution/node/146/log

@mchaarawi mchaarawi force-pushed the mschaara/dfs_foclass branch from ff0452b to 34f0383 Compare November 7, 2022 19:55
daosbuild1
daosbuild1 reviewed Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mchaarawi mchaarawi force-pushed the mschaara/dfs_foclass branch from 34f0383 to 592ed67 Compare November 7, 2022 20:10
daosbuild1
daosbuild1 reviewed Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mchaarawi mchaarawi force-pushed the mschaara/dfs_foclass branch from 592ed67 to f55fe15 Compare November 7, 2022 20:39
@daosbuild1
Copy link
Collaborator

daosbuild1 commented Nov 7, 2022

Test stage NLT on EL 8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-10786/5/display/redirect

daosbuild1
daosbuild1 reviewed Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

daosbuild1 commented Nov 7, 2022

Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-10786/6/testReport/(root)/

@mchaarawi
DAOS-12038 dfs: add file_oclass option for DFS container creation
00c75b4 
- Change oclass to be the default for all objects, and add a new option for
file_oclass (dir_oclass is already there).

Features: dfs
Required-githooks: true

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
@mchaarawi mchaarawi force-pushed the mschaara/dfs_foclass branch from f55fe15 to 00c75b4 Compare November 7, 2022 23:04
daosbuild1
daosbuild1 reviewed Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

daosbuild1 commented Nov 8, 2022

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10786/8/execution/node/1084/log

@mchaarawi mchaarawi marked this pull request as ready for review November 8, 2022 18:35
@mchaarawi mchaarawi requested review from a team as code owners November 8, 2022 18:35
@mchaarawi mchaarawi requested review from ashleypittman, daltonbohning, knard38 and mjmac and removed request for a team November 8, 2022 18:35
@mchaarawi mchaarawi requested a review from wiliamhuang November 8, 2022 18:35
daltonbohning
daltonbohning approved these changes Nov 8, 2022
View reviewed changes
knard38
knard38 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchaarawi
Copy link
Contributor Author

mchaarawi commented Nov 9, 2022

osa/online_extend failure only: https://daosio.atlassian.net/browse/DAOS-12031

@mchaarawi mchaarawi requested a review from a team November 9, 2022 14:11
@mchaarawi mchaarawi added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Nov 10, 2022
@jolivier23 jolivier23 merged commit bc506bf into master Nov 10, 2022
@jolivier23 jolivier23 deleted the mschaara/dfs_foclass branch November 10, 2022 19:26
wangzhaorong-cestc pushed a commit to wangzhaorong-cestc/daos that referenced this pull request Nov 20, 2022
@mchaarawi @wangzhaorong-cestc
DAOS-12038 dfs: add file_oclass option for DFS container creation (da…
df25b7a 
…os-stack#10786)

- Change oclass to be the default for all objects, and add a new option for
file_oclass (dir_oclass is already there).

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
@mjmac mjmac mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@daosbuild1 daosbuild1 daosbuild1 left review comments

@knard38 knard38 knard38 approved these changes

@mjmac mjmac Awaiting requested review from mjmac mjmac is a code owner automatically assigned from daos-stack/go-watchers

@ashleypittman ashleypittman Awaiting requested review from ashleypittman

@wiliamhuang wiliamhuang Awaiting requested review from wiliamhuang

Assignees

No one assigned

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mchaarawi @daosbuild1 @daltonbohning @knard38 @jolivier23