Skip to content

DAOS-13539 control: Fix network related commands for multiprovider#12255

Merged
kjacque merged 1 commit intofeature/multiproviderfrom
kjacque/multiprovider/net-fixes
Jun 2, 2023
Merged

DAOS-13539 control: Fix network related commands for multiprovider#12255
kjacque merged 1 commit intofeature/multiproviderfrom
kjacque/multiprovider/net-fixes

Conversation

@kjacque
Copy link
Copy Markdown
Contributor

@kjacque kjacque commented Jun 1, 2023

  • By default dmg network scan will include all configured providers, not just the primary provider.
  • In daos_agent dump-attachinfo, use the agent config as the source for the provider index.

Features: control

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

- By default dmg network scan will include all configured providers,
  not just the primary provider.
- In daos_agent dump-attachinfo, use the agent config as the source
  for the provider index.

Features: control

Required-githooks: true

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@kjacque kjacque self-assigned this Jun 1, 2023
@kjacque kjacque requested a review from a team as a code owner June 1, 2023 19:32
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 1, 2023

Bug-tracker data:
Ticket title is 'feature/multiprovider: dmg network scan and daos_agent dump-getattachinfo show primary provider even when running on secondary'
Status is 'In Review'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-13539

Copy link
Copy Markdown
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link
Copy Markdown
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for what I understand.

@kjacque kjacque merged commit 9839c64 into feature/multiprovider Jun 2, 2023
@kjacque kjacque deleted the kjacque/multiprovider/net-fixes branch June 2, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants