Skip to content

Conversation

@NiuYawei
Copy link
Contributor

Destroy the container in reintegration discard phase, otherwise the orphan container might be left after reintegration and causing trouble in reclaim phase.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Destroy the container in reintegration discard phase,
otherwise the orphan container might be left after reintegration
and causing trouble in reclaim phase.

Signed-off-by: Di Wang <di.wang@intel.com>
@NiuYawei NiuYawei requested review from a team as code owners June 11, 2024 00:49
@NiuYawei NiuYawei added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jun 11, 2024
@github-actions
Copy link

github-actions bot commented Jun 11, 2024

Ticket title is 'The container is not destroyed during reintegration discard, which may cause reintegration failure.'
Status is 'Awaiting backport'
Labels: 'scrubbed_2.8,triaged'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-15391

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jun 12, 2024
@gnailzenh gnailzenh merged commit 9aa17e4 into release/2.6 Jun 14, 2024
@gnailzenh gnailzenh deleted the wangdi/daos_15391_b26 branch June 14, 2024 07:26
@mjmac mjmac mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed)

Development

Successfully merging this pull request may close these issues.

6 participants