Skip to content

Conversation

@jolivier23
Copy link
Contributor

--disable-wb-caching should be --disable-wb-cache

Doc-only: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

--disable-wb-caching should be --disable-wb-cache

Doc-only: true

Required-githooks: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 requested a review from a team as a code owner August 20, 2024 16:59
@jolivier23 jolivier23 requested a review from mchaarawi August 20, 2024 16:59
@jolivier23 jolivier23 added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Aug 20, 2024
@github-actions
Copy link

Ticket title is 'documentation should use --disable-wb-cache, not --disable-wb-caching'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16368

@jolivier23 jolivier23 added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 20, 2024
@mchaarawi mchaarawi merged commit edfbb0d into release/2.6 Aug 20, 2024
@mchaarawi mchaarawi deleted the jvolivie/26_doc_fix branch August 20, 2024 17:01
@mjmac mjmac mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Development

Successfully merging this pull request may close these issues.

3 participants