Skip to content

Conversation

@knard38
Copy link
Contributor

@knard38 knard38 commented Aug 23, 2024

description

Clean cherry pick of the PR #14995

Hotfix of miscellaneous issues:

  • invalid type of atomic_flag
  • invalid usage of DL_WARN macro

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Hotfix of miscellaneous issues:
- invalid type of atomic_flag
- invalid usage of DL_WARN macro

Required-githooks: true

Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@intel.com>
@knard38 knard38 self-assigned this Aug 23, 2024
@github-actions
Copy link

Ticket title is 'pil4dfs dentry caching'
Status is 'Resolved'
Labels: 'intercept_lib'
https://daosio.atlassian.net/browse/DAOS-14348

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14996/1/testReport/

@knard38 knard38 added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Aug 30, 2024
@knard38 knard38 marked this pull request as ready for review August 30, 2024 14:37
@knard38 knard38 requested review from a team as code owners August 30, 2024 14:37
@knard38
Copy link
Contributor Author

knard38 commented Aug 30, 2024

Restart unit test to check if NLT error is a real issue.
It seems that NLT was not stable these last times.

@knard38 knard38 requested a review from a team September 2, 2024 18:32
@knard38
Copy link
Contributor Author

knard38 commented Sep 2, 2024

@daos-stack/daos-gatekeeper please could you lend this PR with the following message:

  • Title: DAOS-14348 client: GC for pil4dfs dentry cache
  • Body:
Hotfix of miscellaneous issues:
- invalid type of atomic_flag
- invalid usage of DL_WARN macro

NB: as it is a clean cherry-pick only one approval should be needed.

@mchaarawi mchaarawi merged commit f12df7f into release/2.6 Sep 3, 2024
@mchaarawi mchaarawi deleted the ckochhof/hotfix/v2.6.1/daos-14348 branch September 3, 2024 13:12
@mjmac mjmac mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-cherry-pick Cherry-pick from another branch that did not require additional edits

Development

Successfully merging this pull request may close these issues.

6 participants