Skip to content

DAOS-16480 test: Increase expected range for dirty_pages metric #15097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daltonbohning merged 1 commit into from
Sep 16, 2024
Merged

DAOS-16480 test: Increase expected range for dirty_pages metric #15097

daltonbohning merged 1 commit into from
Sep 16, 2024

Conversation

@phender
Copy link
Contributor

@phender phender commented Sep 6, 2024 •
edited
Loading

Increase the upper expected bounds for the
engine_pool_checkpoint_dirty_pages_samples metric.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-large-md-on-ssd: false

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-16480 test: Increase expected range for dirty_pages metric
183a456 
Increae the upper expected bounds for the
engine_pool_checkpoint_dirty_pages_samples metric.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-large-md-on-ssd: false

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested review from a team as code owners September 6, 2024 20:56
@phender phender requested a review from NiuYawei September 6, 2024 20:57
@github-actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

Ticket title is 'telemetry/wal_metrics.py:WalMetrics.test_wal_checkpoint_metrics - engine_pool_checkpoint_dirty_pages_samples > 3'
Status is 'In Review'
Labels: 'ci_master_daily,daily_test,md_on_ssd'
https://daosio.atlassian.net/browse/DAOS-16480

@phender phender requested a review from a team September 16, 2024 15:41
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 16, 2024
@phender
Copy link
Contributor Author

phender commented Sep 16, 2024

Test passed in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15097/2/testReport/FTEST_telemetry/

@daltonbohning daltonbohning merged commit 6d5f00e into master Sep 16, 2024
@daltonbohning daltonbohning deleted the pahender/DAOS-16480 branch September 16, 2024 16:08
phender added a commit that referenced this pull request Sep 16, 2024
@phender
DAOS-16480 test: Increase expected range for dirty_pages metric (#15097)
1ddc5c1 
Increase the upper expected bounds for the
engine_pool_checkpoint_dirty_pages_samples metric.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-large-md-on-ssd: false

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
daltonbohning pushed a commit that referenced this pull request Oct 4, 2024
@phender
DAOS-16480 test: Increase expected range for dirty_pages metric (#15097…
16cc101 
…) (#15136)

Increase the upper expected bounds for the
engine_pool_checkpoint_dirty_pages_samples metric.

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
This was referenced Oct 7, 2024
Closed
Closed
This was referenced Oct 8, 2024
Closed
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
@mjmac mjmac mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NiuYawei NiuYawei NiuYawei approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees

No one assigned

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@phender @NiuYawei @daltonbohning