Skip to content

DAOS-16807 client: intercept io_queue_init in libpil4dfs#15497

Merged
mchaarawi merged 3 commits intomasterfrom
lei/DAOS-16807
Dec 5, 2024
Merged

DAOS-16807 client: intercept io_queue_init in libpil4dfs#15497
mchaarawi merged 3 commits intomasterfrom
lei/DAOS-16807

Conversation

@wiliamhuang
Copy link
Copy Markdown
Contributor

Intercepting io_queue_init() is needed on Ubuntu. There is compatibility issue for pil4dfs interception library when used with fio libaio engine. In some cases, fio initialize the aio context through io_queue_init function when loading the libaio engine. Through the pil4dfs has intercepted the io_setup function, but it seems that the io_setup which called by io_queue_init is not intercepted some times, which causing invalid aio context for I/O processing. So add an interception for io_queue_init to make it work for this case.

Features: pil4dfs

Required-githooks: true
Skipped-githooks: codespell

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Intercepting io_queue_init() is needed on Ubuntu.

Features: pil4dfs

Required-githooks: true
Skipped-githooks: codespell

Signed-off-by: Jun Zeng <jun1.zeng@intel.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 13, 2024

Ticket title is 'fio segfault when running with interception library libpil4dfs.so'
Status is 'Open'
Labels: 'intercept_lib'
https://daosio.atlassian.net/browse/DAOS-16807

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15497/1/testReport/

Features: pil4dfs
Allow-unstable-test: true

Required-githooks: true
Skipped-githooks: codespell

Signed-off-by: Lei Huang <lei.huang@intel.com>
@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15497/2/testReport/

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15497/2/execution/node/1191/log

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15497/4/testReport/

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15497/4/execution/node/1190/log

Features: pil4dfs
Allow-unstable-test: true

Required-githooks: true
Skipped-githooks: codespell
@wiliamhuang wiliamhuang marked this pull request as ready for review December 2, 2024 14:50
@wiliamhuang wiliamhuang requested review from a team as code owners December 2, 2024 14:50
@wiliamhuang
Copy link
Copy Markdown
Contributor Author

wiliamhuang commented Dec 2, 2024

This PR was originally contributed by @junzeng1 from Intel (#15462) although I also developed a similar patch locally independently. It looks good to me.

Copy link
Copy Markdown
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchaarawi mchaarawi merged commit 24b2712 into master Dec 5, 2024
@mchaarawi mchaarawi deleted the lei/DAOS-16807 branch December 5, 2024 20:47
wiliamhuang pushed a commit that referenced this pull request Jan 24, 2025
Intercepting io_queue_init() is needed on Ubuntu. There is compatibility issue for pil4dfs interception library when used with fio libaio engine. In some cases, fio initialize the aio context through io_queue_init function when loading the libaio engine. Through the pil4dfs has intercepted the io_setup function, but it seems that the io_setup which called by io_queue_init is not intercepted some times, which causing invalid aio context for I/O processing. So add an interception for io_queue_init to make it work for this case.

Signed-off-by: Jun Zeng <jun1.zeng@intel.com>
Signed-off-by: Lei Huang <lei.huang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants