Skip to content

DAOS-16903 build: Update golang.org/x/net to 0.33.0#15650

Merged
mjmac merged 2 commits intomasterfrom
kjacque/golang-x-net-0.33.0
Dec 20, 2024
Merged

DAOS-16903 build: Update golang.org/x/net to 0.33.0#15650
mjmac merged 2 commits intomasterfrom
kjacque/golang-x-net-0.33.0

Conversation

@kjacque
Copy link
Copy Markdown
Contributor

@kjacque kjacque commented Dec 19, 2024 •
edited
Loading

  • Update go.mod.
  • Update vendored dependencies.
  • Exclude Go vendored dependencies from codespell githook.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kjacque
DAOS-16903 build: Update golang.org/x/net to 0.33.0
ceca71b 
- Update go.mod.
- Update vendored dependencies.
- Exclude Go vendored dependencies from codespell githook.

Required-githooks: true

Signed-off-by: Kris Jacque <kristin.jacque@hpe.com>
@kjacque kjacque self-assigned this Dec 19, 2024
@kjacque kjacque requested review from a team as code owners December 19, 2024 21:20
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 19, 2024 •
edited
Loading

Ticket title is 'Security update required: golang.org/x/net'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16903

@kjacque
Copy link
Copy Markdown
Contributor Author

kjacque commented Dec 19, 2024

Build and githook changes only. No Feature/Test-tags needed.

mjmac
mjmac previously approved these changes Dec 19, 2024
View reviewed changes
@daltonbohning
fix codespell skip handling
d264919 
Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
@daltonbohning daltonbohning force-pushed the kjacque/golang-x-net-0.33.0 branch from f1c0f50 to d264919 Compare December 19, 2024 22:43
@daltonbohning daltonbohning requested a review from mjmac December 19, 2024 22:44
knard38
knard38 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for what I understand

@mjmac mjmac merged commit 23fe212 into master Dec 20, 2024
@mjmac mjmac deleted the kjacque/golang-x-net-0.33.0 branch December 20, 2024 14:24
mlawsonca pushed a commit that referenced this pull request Dec 27, 2024
@kjacque @daltonbohning @mlawsonca
DAOS-16903 build: Update golang.org/x/net to 0.33.0 (#15650)
7f0d80d 
- Update go.mod.
- Update vendored dependencies.
- Exclude Go vendored dependencies from codespell githook.
- Fix codespell skip handling.

Signed-off-by: Kris Jacque <kristin.jacque@hpe.com>
Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
Co-authored-by: Dalton Bohning <dalton.bohning@hpe.com>
jolivier23 pushed a commit that referenced this pull request Dec 27, 2024
@mlawsonca
DAOS-16903 build: Update golang.org/x/net to 0.33.0 (#15650) (#15666)
86279b1 
- Update go.mod.
- Update vendored dependencies.
- Exclude Go vendored dependencies from codespell githook.
- Fix codespell skip handling.

Signed-off-by: Kris Jacque <kristin.jacque@hpe.com>
Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
kjacque added a commit that referenced this pull request Jan 8, 2025
@kjacque @daltonbohning
DAOS-16903 build: Update golang.org/x/net to 0.33.0 (#15650)
393e7b4 
- Update go.mod.
- Update vendored dependencies.
- Exclude Go vendored dependencies from codespell githook.
- Fix codespell skip handling.

Signed-off-by: Kris Jacque <kristin.jacque@hpe.com>
Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
Co-authored-by: Dalton Bohning <dalton.bohning@hpe.com>
daltonbohning added a commit that referenced this pull request Jan 10, 2025
@kjacque @daltonbohning
DAOS-16903 build: Update golang.org/x/net to 0.33.0 (#15650) (#15704)
f7bd956 
- Update go.mod.
- Update vendored dependencies.
- Exclude Go vendored dependencies from codespell githook.
- Fix codespell skip handling.

Signed-off-by: Kris Jacque <kristin.jacque@hpe.com>
Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
Co-authored-by: Dalton Bohning <dalton.bohning@hpe.com>
@mjmac mjmac mentioned this pull request Jan 13, 2025
Merged
@mjmac mjmac mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanabarr tanabarr tanabarr approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@knard38 knard38 knard38 approved these changes

@mjmac mjmac Awaiting requested review from mjmac

Assignees

@kjacque kjacque

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kjacque @mjmac @tanabarr @daltonbohning @knard38