Skip to content

DAOS-17207 build: upgrade to SPDK 24.09#16774

Merged
johannlombardi merged 230 commits intomasterfrom
jvolivie/fpm_spdk
Nov 28, 2025
Merged

DAOS-17207 build: upgrade to SPDK 24.09#16774
johannlombardi merged 230 commits intomasterfrom
jvolivie/fpm_spdk

Conversation

@jolivier23
Copy link
Contributor

@jolivier23 jolivier23 commented Aug 27, 2025 •
edited by tanabarr
Loading

Upgrade SPDK version used by DAOS from v22.01 to v24.09 to take
advantage of the numerous improvements. In this change:

  • SPDK API usage in DAOS updated
  • Build updates including those related to DAOS dependency RPMs
  • Control-plane go binding NVMe discovery fix for segfault issue
  • Control-plane go binding NVMe cmocka unit test fix

Co-authored-by Di Wang ddiwang@google.com
Co-authored-by Tom Nabarro thomas.nabarro@hpe.com

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).
    hh

jolivier23 added 30 commits April 25, 2025 19:31
@jolivier23
DAOS-17472 build: Build all RPMs together
7fc7461 
Use a tool called fpm to build RPMs together

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
base daos package and daos-server package
8822947 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Refactor a bit to reduce duplication
6e4ee24 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
fix issue
8ca519d 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
EL8 build
3b1df93 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Try el9 build
d25b573 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Get build working again
62e6a79 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Add a few more changes
b803b78 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
leap, el8, el9 building rpms
a28484d 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
pmdk shellcheck
b6a078c 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Fix source rpm
f1033cb 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Add to change log
080426d 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
fix a few issues
b2a3472 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Merge remote-tracking branch 'comm/master' into jvolivie/fpm
1a8fd93 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Address initial review comments
e655558 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Change user back to 5000
2a19f65 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Got rpms working on EL8
e5bf817 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
A few more changes
fd792e1 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Fixup ubuntu
ced6836 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Empty commit
35463f3 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Oops, missed a file
d1f324a 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Linting fixes
bbdc217 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
DAOS_PACKAGE_BUILD should depend on DAOS_BUILD
42e66cd 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Split the build to take better advantage of cache
00af5a3 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Merge remote-tracking branch 'comm/master' into jvolivie/fpm
081e4b0
@jolivier23
empty commit
7e522f0 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Oops, ubuntu wasn't right
464a596 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Merge remote-tracking branch 'comm/master' into jvolivie/fpm
ebaaf23 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
post merge empty commit
99a56d9 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
DAOS-17207 daos: upgrade to SPDK 24.09
e6398b5 
Upgrade to SPDK24.09

Signed-off-by: Di Wang <ddiwang@google.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Merge branch 'jvolivie/isal_crypto' into jvolivie/fpm_spdk
b662d93 
Change-Id: I83dcca0feb9a4245a5ab1e21ff5570fec97c948e
@jolivier23
Allow-unstable-test: true
151c5d6 
Change-Id: I9fc9f22f22f5f1381ba0d2a5ae4c5ad55c8ac8c8
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
tanabarr
tanabarr previously approved these changes Nov 21, 2025
View reviewed changes
@jolivier23
Merge remote-tracking branch 'comm/master' into jvolivie/isal_crypto
84a1a02 
Change-Id: I1c4e2c960f0f20dfd5106941217adf21ad40f875
@jolivier23
Add an explicit requirement on >= 2.25.0
be29559 
Change-Id: I39e9373b7fec6530e3e05f145bbc9e1fe72f537b
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Merge branch 'jvolivie/isal_crypto' into jvolivie/fpm_spdk
b2f5a7c 
Change-Id: Ibe7d48b38782ee700735f7df1073a69b99979d8d
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Commit after merge
893c497 
Allow-unstable-test: true

Change-Id: I008605c77223b29f44154e25deb752bcc04d220b
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Nov 24, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16774/58/testReport/

Base automatically changed from jvolivie/isal_crypto to master November 26, 2025 00:25
@johannlombardi johannlombardi dismissed stale reviews from tanabarr and NiuYawei November 26, 2025 00:25

The base branch was changed.

@jolivier23
Merge remote-tracking branch 'comm/master' into jvolivie/fpm_spdk
ff9f75d 
Change-Id: I5e16c0cbfaa266ea7adc4ad2606510f0f2c3ab6d
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
After merge change
9e87f3f 
Allow-unstable-test: true
Skip-func-test-el9: false
Skip-func-test-leap15: false

Change-Id: If360a4670ef18a267642923ffee65bef78c40569
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Nov 26, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16774/60/testReport/

@tanabarr
Copy link
Contributor

tanabarr commented Nov 26, 2025

NLT valgrind warnings: https://jenkins.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16774/60/VM_test/ - zero new warnings and no warnings in bio module. Copyright changes were not addressed on rebase but can be addressed as a follow-on.

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Nov 27, 2025

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16774/60/execution/node/1537/log

@jolivier23 jolivier23 requested a review from a team November 27, 2025 20:27
@tanabarr
Copy link
Contributor

tanabarr commented Nov 28, 2025

NLT and copyright warnings explained in previous comment. hardware stage tests all passed after most recent restart from stage. requesting forced landing. @gnailzenh @johannlombardi

@tanabarr tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Nov 28, 2025
@johannlombardi johannlombardi merged commit 8f8b957 into master Nov 28, 2025
65 of 69 checks passed
@johannlombardi johannlombardi deleted the jvolivie/fpm_spdk branch November 28, 2025 13:26
janekmi added a commit that referenced this pull request Feb 26, 2026
@janekmi
DAOS-18597 bio: allow SPDK reinitialization
beb6239 
Ref: spdk/spdk@fba209c
Ref: #16774

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@janekmi janekmi mentioned this pull request Feb 26, 2026
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanabarr tanabarr tanabarr approved these changes

@NiuYawei NiuYawei NiuYawei approved these changes

@wangdi1 wangdi1 Awaiting requested review from wangdi1

Assignees

@tanabarr tanabarr

@jolivier23 jolivier23

@wangdi1 wangdi1

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jolivier23 @daosbuild3 @NiuYawei @tanabarr @wangdi1 @johannlombardi @kjacque