Skip to content

DAOS-17973 control: Allow none for pool property self_heal (#16848)#17217

Merged
daltonbohning merged 3 commits intorelease/2.6from
liw/fix-empty-self_heal-ii-2.6
Feb 6, 2026
Merged

DAOS-17973 control: Allow none for pool property self_heal (#16848)#17217
daltonbohning merged 3 commits intorelease/2.6from
liw/fix-empty-self_heal-ii-2.6

Conversation

@liw
Copy link
Contributor

@liw liw commented Dec 3, 2025 •
edited
Loading

It is impossible to turn off all flags of pool property self_heal, because dmg pool set-prop disallows empty value syntax. This patch adds "none" as a valid value for pool property self_heal, to indicate that all flags are turned off.

To avoid introducing test failures, this PR also includes DAOS-18478 backports.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@liw liw added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Ticket title is 'dmg set-prop self_heal should be able to accept empty string value'
Status is 'Awaiting backport'
Labels: 'scrubbed_2.6.5'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-17973

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 3, 2025
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 3, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/1/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 3, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/2/testReport/

@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from 68614e6 to 6cb808d Compare December 7, 2025 23:45
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 8, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/3/testReport/

@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from 6cb808d to 449a2b2 Compare December 15, 2025 00:08
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 15, 2025

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17217/4/execution/node/1530/log

@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from 449a2b2 to ee0644a Compare December 24, 2025 04:55
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 24, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/5/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 24, 2025

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17217/5/execution/node/1523/log

@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from ee0644a to fdc8bc7 Compare January 6, 2026 04:41
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 6, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/6/testReport/

@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from fdc8bc7 to a0b9e30 Compare January 7, 2026 02:34
@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from a0b9e30 to cd66fa0 Compare January 15, 2026 02:56
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 15, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/8/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 15, 2026

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17217/8/execution/node/1577/log

@liw
Copy link
Contributor Author

liw commented Jan 19, 2026

Needs to wait for #17401.

@liw liw removed the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jan 26, 2026
@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from cd66fa0 to cab15c0 Compare January 26, 2026 00:30
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 26, 2026

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17217/9/execution/node/1496/log

liw added 3 commits February 3, 2026 10:08
@liw
DAOS-17973 control: Allow none for pool property self_heal (#16848)
0c44dd7 
It is impossible to turn off all flags of pool property self_heal,
because dmg pool set-prop disallows empty value syntax. This patch adds
"none" as a valid value for pool property self_heal, to indicate that
all flags are turned off.

Signed-off-by: Li Wei <liwei@hpe.com>
@liw
DAOS-18478 tests: Fix daos_test POOL13 (#17401)
4da3eaa 
daos_test POOL13 should restore the original value of pool property
self_heal, or later tests may be affected.

Signed-off-by: Li Wei <liwei@hpe.com>
@liw
DAOS-18478 tests: Escape self_heal value in POOL13 (#17475)
ac7f134 
When calling daos_pool_set_prop for self_heal, we have to escape the
';'s in the value.

With this fix POOL16 and POOL17 rebuild tasks will start properly. And,
due to #17028, each rebuild task takes 10 s longer now. Hence, we have
to increase the test timeout.

Signed-off-by: Li Wei <liwei@hpe.com>
@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from cab15c0 to ac7f134 Compare February 3, 2026 01:15
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 3, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/10/testReport/

@liw liw marked this pull request as ready for review February 6, 2026 05:09
@liw liw requested review from a team as code owners February 6, 2026 05:09
@liw liw requested review from a team as code owners February 6, 2026 05:09
@liw liw requested review from kccain, kjacque and tanabarr February 6, 2026 05:12
daltonbohning
daltonbohning reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM

@daltonbohning daltonbohning requested a review from a team February 6, 2026 18:37
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Feb 6, 2026
@daltonbohning daltonbohning merged commit 9b4eb92 into release/2.6 Feb 6, 2026
43 of 45 checks passed
@daltonbohning daltonbohning deleted the liw/fix-empty-self_heal-ii-2.6 branch February 6, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

@tanabarr tanabarr tanabarr approved these changes

@kccain kccain kccain approved these changes

@kjacque kjacque Awaiting requested review from kjacque

Assignees

No one assigned

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liw @daosbuild3 @tanabarr @daltonbohning @kccain