Skip to content

DAOS-17861 cart: fix err handling in corpc (#17299)#17328

Merged
gnailzenh merged 3 commits intorelease/2.6from
lxz/corpc_err_fix_26
Jan 27, 2026
Merged

DAOS-17861 cart: fix err handling in corpc (#17299)#17328
gnailzenh merged 3 commits intorelease/2.6from
lxz/corpc_err_fix_26

Conversation

@liuxuezhao
Copy link
Copy Markdown
Contributor

@liuxuezhao liuxuezhao commented Dec 30, 2025

  1. Some fail cases already set the rc by crt_corpc_fail_parent_rpc()/ crt_corpc_fail_child_rpc(), or called crt_corpc_complete() that will reply parent already, so need to reset rc to 0 to avoid call crt_hg_reply_error_send() again or drop refcount.
  2. Fix a refcount leak in a case when need not call local RPC handler in middle node.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@liuxuezhao liuxuezhao requested review from a team as code owners December 30, 2025 15:49
@liuxuezhao liuxuezhao added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Dec 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 30, 2025 •
edited
Loading

Ticket title is 'Segmentation fault against UCX provider during CR test'
Status is 'Awaiting backport'
Labels: '2.8pp,scrubbed_2.6.5,scrubbed_2.8'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-17861

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Dec 30, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17328/1/testReport/

Nasf-Fan
Nasf-Fan previously approved these changes Dec 31, 2025
View reviewed changes
@github-actions github-actions Bot added the priority Ticket has high priority (automatically managed) label Jan 16, 2026
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Jan 16, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17328/2/testReport/

@liuxuezhao
DAOS-17861 cart: fix err handling in corpc (#17299)
c9f78f1 
1. Some fail cases already set the rc by crt_corpc_fail_parent_rpc()/
   crt_corpc_fail_child_rpc(), or called crt_corpc_complete() that will
   reply parent already, so need to reset rc to 0 to avoid call
   crt_hg_reply_error_send() again or drop refcount.
2. Fix a refcount leak in a case when need not call local RPC handler
   in middle node.

Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
@liuxuezhao liuxuezhao force-pushed the lxz/corpc_err_fix_26 branch from abac378 to c9f78f1 Compare January 16, 2026 15:50
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Jan 16, 2026

Test stage Functional Hardware Medium completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17328/2/execution/node/1514/log

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Jan 26, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17328/5/testReport/

@liuxuezhao liuxuezhao requested a review from a team January 27, 2026 02:06
@liuxuezhao liuxuezhao added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 27, 2026
@gnailzenh gnailzenh merged commit d381b32 into release/2.6 Jan 27, 2026
42 of 44 checks passed
@gnailzenh gnailzenh deleted the lxz/corpc_err_fix_26 branch January 27, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnailzenh gnailzenh gnailzenh approved these changes

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

@frostedcmos frostedcmos frostedcmos approved these changes

Assignees

No one assigned

Labels

clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liuxuezhao @daosbuild3 @gnailzenh @Nasf-Fan @frostedcmos