Skip to content

DAOS-17321 ddb: Add checksum dump function to ddb vos API #17365

Draft
knard38 wants to merge 10 commits into
masterfrom
ckochhof/dev/master/daos-17321-part-002
Draft

DAOS-17321 ddb: Add checksum dump function to ddb vos API #17365
knard38 wants to merge 10 commits into
masterfrom
ckochhof/dev/master/daos-17321-part-002

Conversation

@knard38
Copy link
Copy Markdown
Contributor

@knard38 knard38 commented Jan 12, 2026

Description

TODO

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Remove ddb C legacy code related to command line parsing, mini-shell,
etc.

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@knard38 knard38 self-assigned this Jan 12, 2026
@knard38 knard38 added the CR Catastrophic Recovery Feature label Jan 12, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 12, 2026

Ticket title is 'Checksum management with ddb'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-17321

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17365/1/testReport/

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17365/1/execution/node/1334/log

@knard38 knard38 force-pushed the ckochhof/dev/master/daos-17321-part-002 branch 2 times, most recently from 92d5862 to 5553846 Compare January 22, 2026 15:02
@daosbuild3
Copy link
Copy Markdown
Collaborator

Properly configure C DAOS debug facilities from Golang DDB code.

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@knard38 knard38 force-pushed the ckochhof/fix/master/daos-18323 branch 2 times, most recently from 08b5a70 to f23c95c Compare January 29, 2026 08:59
Fix ddb vos file path parsing.

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@knard38 knard38 force-pushed the ckochhof/fix/master/daos-18323 branch from f23c95c to c013fe7 Compare January 29, 2026 13:32
@knard38 knard38 force-pushed the ckochhof/dev/master/daos-17321-part-002 branch from 5553846 to 16cdc5a Compare January 29, 2026 15:19
@knard38 knard38 changed the base branch from ckochhof/fix/master/daos-18323 to ckochhof/dev/master/daos-17321-part-001 January 29, 2026 15:44
@knard38 knard38 force-pushed the ckochhof/dev/master/daos-17321-part-001 branch from c1d48c1 to 02b2741 Compare February 2, 2026 15:00
@knard38 knard38 force-pushed the ckochhof/dev/master/daos-17321-part-002 branch from 16cdc5a to 826062f Compare February 2, 2026 15:42
@daosbuild3
Copy link
Copy Markdown
Collaborator

Refactoring DDB code to allow unit testing of the go part code:
- The GO interface DdbApi is introduced to allow the use of GO test stub.
- Refactor initialisation of the C structure from the Go Code to allow the use of GO test stub.
- The useless C attributes dc_pool_path and dc_db_path are removed.

Following issues are also fixed:
- Remove invalid restrictions on pool file path size.
- Improper cleanup of the function ddb_run_feature().
- Fix invalid return code with non-interactive mode
- Fix rm_pool command:
  - Add db_path parameter to pool destroy command.
  - Makes vos_path parameter mandatory to pool destroy command.

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
Add the following unit tests to the ddb Golang code:
    - for the function main.parseOpts.
    - for the ls and open ddb commands.

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
This patch add the support of the flag value `VOS_OF_FETCH_CSUM' to the function `vos_fetch_begin()`.
This new flag allow to fetch related checksum information with this last function.
This information will be needed by the following PR related to checksum management with `ddb`.

Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
Add checksum dump function dv_dump_csum() to ddb vos API.

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@knard38 knard38 force-pushed the ckochhof/dev/master/daos-17321-part-001 branch from 02b2741 to eff767d Compare February 5, 2026 09:19
@knard38 knard38 force-pushed the ckochhof/dev/master/daos-17321-part-002 branch from 826062f to d1ac4ce Compare February 5, 2026 09:19
@daosbuild3
Copy link
Copy Markdown
Collaborator

@daosbuild3
Copy link
Copy Markdown
Collaborator

@knard38 knard38 changed the base branch from ckochhof/dev/master/daos-17321-part-001 to ckochhof/dev/master/daos-17321/patch-001 May 19, 2026 14:29
@knard38 knard38 force-pushed the ckochhof/dev/master/daos-17321/patch-001 branch 3 times, most recently from 998a14f to 2a922ea Compare May 19, 2026 19:12
Base automatically changed from ckochhof/dev/master/daos-17321/patch-001 to master June 4, 2026 14:47
@daosbuild3
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CR Catastrophic Recovery Feature

Development

Successfully merging this pull request may close these issues.

3 participants