Skip to content

DAOS-18238 chk: handle CRT_EVS_GRPMOD event from CaRT PG - b26#17460

Merged
gnailzenh merged 1 commit intorelease/2.6from
Nasf-Fan/DAOS-18238_1_b26
Feb 5, 2026
Merged

DAOS-18238 chk: handle CRT_EVS_GRPMOD event from CaRT PG - b26#17460
gnailzenh merged 1 commit intorelease/2.6from
Nasf-Fan/DAOS-18238_1_b26

Conversation

@Nasf-Fan
Copy link
Contributor

To guarantee that the rank deatch event will not be omitted, related CR logic needs handle the event from both SWIM and CaRT PG, although there will be a lot of useless event callback.

Test-tag: recovery

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions
Copy link

github-actions bot commented Jan 27, 2026

Ticket title is 'recovery/cat_recov_core.py:CatRecovCoreTest.test_daos_cat_recov_core - CR20-28 failed - 1 rank adminexcluded, others checkerstarted'
Status is 'In Review'
Labels: '2.6.4-aurora.p1,2.8.0tb1,ci_master_daily,ci_master_provider,daily_test'
https://daosio.atlassian.net/browse/DAOS-18238

@Nasf-Fan
Copy link
Contributor Author

NOTE: do not land this patch until the patch #17428 has been landed, otherwise there may be merge conflict.

@Nasf-Fan Nasf-Fan changed the base branch from release/2.6 to Nasf-Fan/DAOS-17535_7_b26 January 28, 2026 04:52
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-18238_1_b26 branch from 2079b95 to bbbc63b Compare January 28, 2026 04:52
Base automatically changed from Nasf-Fan/DAOS-17535_7_b26 to release/2.6 January 29, 2026 04:23
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-18238_1_b26 branch from bbbc63b to f717cb2 Compare January 29, 2026 04:36
@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17460/5/execution/node/1456/log

To guarantee that the rank deatch event will not be omitted, related
CR logic needs handle the event from both SWIM and CaRT PG, although
there will be a lot of useless event callback.

Test-tag: recovery

Signed-off-by: Fan Yong <fan.yong@hpe.com>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-18238_1_b26 branch from f717cb2 to c7eb5d2 Compare January 30, 2026 03:03
@Nasf-Fan Nasf-Fan marked this pull request as ready for review February 2, 2026 01:06
@Nasf-Fan Nasf-Fan requested review from gnailzenh and liw February 2, 2026 01:07
D_GOTO(out, rc = -DER_NOMEM);

cdr->cdr_rank = rank;
} else if (d_list_empty(&ins->ci_dead_ranks)) {
Copy link
Contributor

@liw liw Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Note] Same comment here as that for the master version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Note] Same comment here as that for the master version.

I thought we got the agreement on that in master PR#17459.

@Nasf-Fan Nasf-Fan requested a review from a team February 5, 2026 00:39
@gnailzenh gnailzenh merged commit 5867d45 into release/2.6 Feb 5, 2026
43 checks passed
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-18238_1_b26 branch February 5, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants