-
Notifications
You must be signed in to change notification settings - Fork 341
DAOS-18529 test: expand/add a few suppressions #17471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-18529 test: expand/add a few suppressions #17471
Conversation
|
Ticket title is 'Too narrow __tsan_go_atomic64_load suppression and more' |
{
<insert_a_suppression_name_here>
Memcheck:Addr8
fun:atomic_load<__sanitizer::atomic_uint64_t>
fun:NoTsanAtomicLoad<unsigned long long>
fun:AtomicLoad<unsigned long long>
fun:__tsan_go_atomic64_load
fun:racecall
}
Test-tag: pr,memcheck
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
1593668 to
ca3286d
Compare
|
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17471/2/testReport/ |
{
<insert_a_suppression_name_here>
Memcheck:Value8
fun:MemoryAccess
fun:__tsan_read_pc
fun:racecall
}
{
<insert_a_suppression_name_here>
Memcheck:Value8
fun:atomic_store<__sanitizer::atomic_uint32_t>
fun:StoreShadow
fun:CheckRaces
fun:MemoryAccess
fun:__tsan_write_pc
fun:racecall
}
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
…expand-__tsan_go_atomic64_load Test-tag: pr,memcheck Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
{
<insert_a_suppression_name_here>
Memcheck:Addr8
fun:atomic_store<__sanitizer::atomic_uint64_t>
fun:NoTsanAtomicStore<unsigned long long>
fun:AtomicStore<unsigned long long>
fun:__tsan_go_atomic64_store
fun:racecall
}
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
No evidence yet but these are expected to follow the same pattern: - __tsan_go_atomic64_compare_exchange - __tsan_go_atomic32_load - __tsan_go_atomic32_store - __tsan_go_atomic32_compare_exchange - __tsan_go_atomic32_fetch_add - __tsan_go_atomic64_fetch_add Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Do we know why NLT is marked as unstable? It seems unlikely, but is it possible this change is affecting something? |
Looking at the results, it seems like NLT just flagged some |
{
<insert_a_suppression_name_here>
Memcheck:Addr8
fun:atomic_load<__sanitizer::atomic_uint64_t>
fun:NoTsanAtomicLoad<unsigned long long>
fun:AtomicLoad<unsigned long long>
fun:__tsan_go_atomic64_load
fun:racecall
}
{
<insert_a_suppression_name_here>
Memcheck:Addr8
fun:atomic_store<__sanitizer::atomic_uint64_t>
fun:NoTsanAtomicStore<unsigned long long>
fun:AtomicStore<unsigned long long>
fun:__tsan_go_atomic64_store
fun:racecall
}
{
<insert_a_suppression_name_here>
Memcheck:Value8
fun:MemoryAccess
fun:__tsan_read_pc
fun:racecall
}
{
<insert_a_suppression_name_here>
Memcheck:Value8
fun:atomic_store<__sanitizer::atomic_uint32_t>
fun:StoreShadow
fun:CheckRaces
fun:MemoryAccess
fun:__tsan_write_pc
fun:racecall
}
{
<insert_a_suppression_name_here>
Memcheck:Addr8
fun:func_add<unsigned long long>
fun:NoTsanAtomicFetchAdd<unsigned long long>
fun:__tsan_go_atomic64_fetch_add
fun:racecall
}
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Ref: #17471 { <insert_a_suppression_name_here> Memcheck:Value8 fun:atomic_load<__sanitizer::atomic_uint32_t> fun:LoadShadow fun:ContainsSameAccess fun:MemoryAccessRangeOne fun:_ZN6__tsan18MemoryAccessRangeTILb0EEEvPNS_11ThreadStateEmmm fun:racecall } { <insert_a_suppression_name_here> Memcheck:Value8 fun:atomic_load<__sanitizer::atomic_uint32_t> fun:LoadShadow fun:CheckRaces fun:MemoryAccessRangeOne fun:_ZN6__tsan18MemoryAccessRangeTILb1EEEvPNS_11ThreadStateEmmm fun:racecall } { <insert_a_suppression_name_here> Memcheck:Value8 fun:atomic_store<__sanitizer::atomic_uint32_t> fun:StoreShadow fun:CheckRaces fun:MemoryAccessRangeOne fun:_ZN6__tsan18MemoryAccessRangeTILb1EEEvPNS_11ThreadStateEmmm fun:racecall } { <insert_a_suppression_name_here> Memcheck:Value8 fun:atomic_load<__sanitizer::atomic_uint32_t> fun:LoadShadow fun:ContainsSameAccess fun:MemoryAccess fun:__tsan_write fun:racecall } { <insert_a_suppression_name_here> Memcheck:Value8 fun:atomic_load<__sanitizer::atomic_uint32_t> fun:LoadShadow fun:CheckRaces fun:MemoryAccess fun:__tsan_write fun:racecall } { <insert_a_suppression_name_here> Memcheck:Value8 fun:MemoryAccess fun:__tsan_read fun:racecall } { <insert_a_suppression_name_here> Memcheck:Value8 fun:atomic_load<__sanitizer::atomic_uint32_t> fun:LoadShadow fun:CheckRaces fun:MemoryAccess fun:__tsan_read fun:racecall } { <insert_a_suppression_name_here> Memcheck:Value8 fun:atomic_store<__sanitizer::atomic_uint32_t> fun:StoreShadow fun:CheckRaces fun:MemoryAccess fun:__tsan_read fun:racecall } Test-tag: pr,memcheck Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Steps for the author:
After all prior steps are complete: