Skip to content

Conversation

@janekmi
Copy link
Contributor

@janekmi janekmi commented Jan 28, 2026

{
   <insert_a_suppression_name_here>
   Memcheck:Addr8
   fun:atomic_load<__sanitizer::atomic_uint64_t>
   fun:NoTsanAtomicLoad<unsigned long long>
   fun:AtomicLoad<unsigned long long>
   fun:__tsan_go_atomic64_load
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Addr8
   fun:atomic_store<__sanitizer::atomic_uint64_t>
   fun:NoTsanAtomicStore<unsigned long long>
   fun:AtomicStore<unsigned long long>
   fun:__tsan_go_atomic64_store
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:MemoryAccess
   fun:__tsan_read_pc
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:atomic_store<__sanitizer::atomic_uint32_t>
   fun:StoreShadow
   fun:CheckRaces
   fun:MemoryAccess
   fun:__tsan_write_pc
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Addr8
   fun:func_add<unsigned long long>
   fun:NoTsanAtomicFetchAdd<unsigned long long>
   fun:__tsan_go_atomic64_fetch_add
   fun:racecall
}

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@janekmi janekmi requested review from a team as code owners January 28, 2026 12:06
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Ticket title is 'Too narrow __tsan_go_atomic64_load suppression and more'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-18529

{
   <insert_a_suppression_name_here>
   Memcheck:Addr8
   fun:atomic_load<__sanitizer::atomic_uint64_t>
   fun:NoTsanAtomicLoad<unsigned long long>
   fun:AtomicLoad<unsigned long long>
   fun:__tsan_go_atomic64_load
   fun:racecall
}

Test-tag: pr,memcheck

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@janekmi janekmi force-pushed the janekmi/DAOS-18529-expand-__tsan_go_atomic64_load branch from 1593668 to ca3286d Compare January 28, 2026 12:09
@daosbuild3
Copy link
Collaborator

soumagne
soumagne previously approved these changes Jan 28, 2026
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:MemoryAccess
   fun:__tsan_read_pc
   fun:racecall
}

{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:atomic_store<__sanitizer::atomic_uint32_t>
   fun:StoreShadow
   fun:CheckRaces
   fun:MemoryAccess
   fun:__tsan_write_pc
   fun:racecall
}

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@janekmi janekmi changed the title DAOS-18529 test: expand __tsan_go_atomic64_load suppression DAOS-18529 test: expand __tsan_go_atomic64_load and __tsan_(write|read)_pc suppressions Feb 5, 2026
@janekmi janekmi changed the title DAOS-18529 test: expand __tsan_go_atomic64_load and __tsan_(write|read)_pc suppressions DAOS-18529 test: expand a few __tsan_* suppressions Feb 5, 2026
…expand-__tsan_go_atomic64_load

Test-tag: pr,memcheck

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
{
   <insert_a_suppression_name_here>
   Memcheck:Addr8
   fun:atomic_store<__sanitizer::atomic_uint64_t>
   fun:NoTsanAtomicStore<unsigned long long>
   fun:AtomicStore<unsigned long long>
   fun:__tsan_go_atomic64_store
   fun:racecall
}

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
No evidence yet but these are expected to follow the same pattern:

- __tsan_go_atomic64_compare_exchange
- __tsan_go_atomic32_load
- __tsan_go_atomic32_store
- __tsan_go_atomic32_compare_exchange
- __tsan_go_atomic32_fetch_add
- __tsan_go_atomic64_fetch_add

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@janekmi janekmi changed the title DAOS-18529 test: expand a few __tsan_* suppressions DAOS-18529 test: expand/add a few suppressions Feb 5, 2026
@janekmi janekmi requested a review from kjacque February 5, 2026 18:24
@janekmi janekmi requested a review from a team February 6, 2026 16:50
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Feb 6, 2026
@daltonbohning
Copy link
Contributor

Do we know why NLT is marked as unstable? It seems unlikely, but is it possible this change is affecting something?

@kjacque
Copy link
Contributor

kjacque commented Feb 6, 2026

Do we know why NLT is marked as unstable? It seems unlikely, but is it possible this change is affecting something?

Looking at the results, it seems like NLT just flagged some -DER_SHUTDOWN errors seen in the logs. No Valgrind errors. The log error stuff is a bit spurious in my opinion, it doesn't always seem to flag something meaningful.

@daltonbohning daltonbohning merged commit 7da8024 into master Feb 6, 2026
43 of 45 checks passed
@daltonbohning daltonbohning deleted the janekmi/DAOS-18529-expand-__tsan_go_atomic64_load branch February 6, 2026 23:17
janekmi added a commit that referenced this pull request Feb 9, 2026
{
   <insert_a_suppression_name_here>
   Memcheck:Addr8
   fun:atomic_load<__sanitizer::atomic_uint64_t>
   fun:NoTsanAtomicLoad<unsigned long long>
   fun:AtomicLoad<unsigned long long>
   fun:__tsan_go_atomic64_load
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Addr8
   fun:atomic_store<__sanitizer::atomic_uint64_t>
   fun:NoTsanAtomicStore<unsigned long long>
   fun:AtomicStore<unsigned long long>
   fun:__tsan_go_atomic64_store
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:MemoryAccess
   fun:__tsan_read_pc
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:atomic_store<__sanitizer::atomic_uint32_t>
   fun:StoreShadow
   fun:CheckRaces
   fun:MemoryAccess
   fun:__tsan_write_pc
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Addr8
   fun:func_add<unsigned long long>
   fun:NoTsanAtomicFetchAdd<unsigned long long>
   fun:__tsan_go_atomic64_fetch_add
   fun:racecall
}

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
janekmi added a commit that referenced this pull request Feb 9, 2026
Ref: #17471

{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:atomic_load<__sanitizer::atomic_uint32_t>
   fun:LoadShadow
   fun:ContainsSameAccess
   fun:MemoryAccessRangeOne
   fun:_ZN6__tsan18MemoryAccessRangeTILb0EEEvPNS_11ThreadStateEmmm
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:atomic_load<__sanitizer::atomic_uint32_t>
   fun:LoadShadow
   fun:CheckRaces
   fun:MemoryAccessRangeOne
   fun:_ZN6__tsan18MemoryAccessRangeTILb1EEEvPNS_11ThreadStateEmmm
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:atomic_store<__sanitizer::atomic_uint32_t>
   fun:StoreShadow
   fun:CheckRaces
   fun:MemoryAccessRangeOne
   fun:_ZN6__tsan18MemoryAccessRangeTILb1EEEvPNS_11ThreadStateEmmm
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:atomic_load<__sanitizer::atomic_uint32_t>
   fun:LoadShadow
   fun:ContainsSameAccess
   fun:MemoryAccess
   fun:__tsan_write
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:atomic_load<__sanitizer::atomic_uint32_t>
   fun:LoadShadow
   fun:CheckRaces
   fun:MemoryAccess
   fun:__tsan_write
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:MemoryAccess
   fun:__tsan_read
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:atomic_load<__sanitizer::atomic_uint32_t>
   fun:LoadShadow
   fun:CheckRaces
   fun:MemoryAccess
   fun:__tsan_read
   fun:racecall
}
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:atomic_store<__sanitizer::atomic_uint32_t>
   fun:StoreShadow
   fun:CheckRaces
   fun:MemoryAccess
   fun:__tsan_read
   fun:racecall
}

Test-tag: pr,memcheck

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Development

Successfully merging this pull request may close these issues.

6 participants