DAOS-18262 common: make sure DAOS file permissions are always 0XXY#17680
DAOS-18262 common: make sure DAOS file permissions are always 0XXY#17680daltonbohning merged 14 commits intomasterfrom
Conversation
At least: - 0660 for files - 0770 for directories. So daos_server group can access DAOS files. Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Ticket title is 'dlck command seems to require sudo privileges. Also hit the DER_NOMEM (-1009) issue.' |
Remove from tgt_create_preallocate() and rdb_create(). Add one in ds_mgmt_create_pool(). Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17680/2/testReport/ |
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Add two constants and apply where possible: - DefaultFilePerm and - DefaultDirPerm Define Mkdir2() as Mkdir() + Chmod(). Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
tanabarr
left a comment
There was a problem hiding this comment.
LGTM, comments are nonblocking and suggestions only
... both for C and Go. Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
- remove other umask() calls - remove chmod() calls Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
... remove SystemProvider.Mkdir2 and use .Mkdir instead. Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
kjacque
left a comment
There was a problem hiding this comment.
Changes overall look good, just some small cleanup requested. Thanks!
... minor fixes in the TestUtils_MkdirForcePerm() test. Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17680/10/testReport/ |
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
…0660 Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
…0660 Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Testing summary ✅
|
At least:
So daos_server group can access DAOS files.
Guide MD-on-PMEM
Guide MD-on-SSD
tree config/daos_control/ config/daos_control/ src/control/server/storage/metadata/provider.go:207 ├── control_raft src/control/system/raft/raft_recovery.go:93 │ ├── daos_system.db src/control/system/raft/raft.go:269 │ └── snapshots No change │ └── 2-39-1773083440395 │ ├── meta.json │ └── state.bin └── engine0 src/control/server/storage/metadata/provider.go:233 ├── daos_nvme.conf src/control/server/storage/bdev/backend_class.go:106 ├── daos_sys src/vos/sys_db.c:131 │ └── sys_db No change └── superblock src/control/common/file_utils.go:141,src/control/server/instance_superblock.go:208Steps for the author:
After all prior steps are complete: