DAOS-18495 md: 24k ABT stack size for md_on_ssd by grom72 · Pull Request #17686 · daos-stack/daos

grom72 · 2026-03-11T06:26:01Z

Increase min ABT stack size to 24k for md_on_ssd

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
Appropriate Functional Test Stages were run.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

github-actions · 2026-03-11T06:26:18Z

Ticket title is 'Random ranks are excluded with signal (6) with master branch.'
Status is 'In Review'
Labels: 'scrubbed_2.8,test_2.8,testp1'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-18495

Increase min ABT stack size to 24k for md_on_ssd Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2

Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

daosbuild3 · 2026-03-11T07:20:30Z

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17686/2/testReport/

daosbuild3 · 2026-03-11T07:24:21Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17686/2/testReport/

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2

Final implementation based on HasBdevRoleMeta(). Tests improvements. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2 Allow-unstable-test: true

daosbuild3 · 2026-03-11T11:41:13Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17686/3/execution/node/1074/log

tanabarr · 2026-03-11T13:01:03Z

src/control/server/engine/config_test.go

+				WithEnvVarAbtThreadStackSize(minABTThreadStackSizeMdOnSsd),
+			expABTthreadStackSize: minABTThreadStackSizeMdOnSsd,
+		},
+		"config for md_on_ssd without thread size should sed ABT_THREAD_STACKSIZE": {


Done: 94a2f4f

tanabarr

nonblocking suggestions, otherwise looks good

tanabarr · 2026-03-11T13:03:01Z

src/control/server/engine/config_test.go

+		t.Run(name, func(t *testing.T) {
+			err := tc.cfg.UpdateABTEnvarsMdOnSsd()
+			test.CmpErr(t, tc.expErr, err)
+			if err == nil {


return early if err != nil rather than nesting here

Done: 94a2f4f

tanabarr · 2026-03-11T13:11:34Z

src/control/server/engine/config_test.go

+			err := tc.cfg.UpdateABTEnvarsMdOnSsd()
+			test.CmpErr(t, tc.expErr, err)
+			if err == nil {
+				if tc.expABTthreadStackSize == 0 {


nit: it would be tidier to run GetEnvVar before if check then perform checks on the result based on expected stack size after e.g. GetEnvVar; if expSS==0 {; Assert(err!=nil); return; }; <note no else clause> Assert(err==nil)....
Generally returning early where possible and reducing nesting to a minimum is seen as a good thing to improve readability of code in Go.

Done: 94a2f4f

Only Unit Tests and NLT to be re-run to confirm that logic has not been changed. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2 Cancel-prev-build: false Skip-unit-test-memcheck: true Skip-test: true Skip-func-test: true Skip-func-vm: true Skip-func-hw-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2 Allow-unstable-test: true

tanabarr

LGTM

…S-18495-ABT_THREAD_STACKSIZE-24k-md-on-ssd" This reverts commit d5bc34e. Priority: 2 Allow-unstable-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

daltonbohning · 2026-03-18T15:10:43Z

Why is this running Functional on EL 8 instead of EL 9?

grom72 · 2026-03-19T07:49:42Z

Why is this running Functional on EL 8 instead of EL 9?

It looks like the Jenkins file parameters haven't been updated correctly:
https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17686/15/parameters/

Revert "Merge remote-tracking branch 'origin/master' into grom72/DAOS…
restore EL 8 as primary functional VM test OS

but
Reapply "Merge remote-tracking branch 'origin/master' into grom72/DAO… did not restore proper (EL9) value.

Next build behaves properly

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2 Skip-unit-tests:true Skip-unit-test: true Skip-NLT: true Skip-unit-test-memcheck: true Skip-fault-injection-test: true Skip-test-el-9.6-rpms: true Skip-test-leap-15-rpms: true Skip-func-hw-test: true

grom72 requested review from NiuYawei and kjacque and removed request for kjacque March 11, 2026 06:33

grom72 added 2 commits March 11, 2026 07:36

DAOS-18495 md: 24k ABT stack size for md_on_ssd

62ddd0c

Increase min ABT stack size to 24k for md_on_ssd Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2

Unit tests for UpdateMdOnSsdStackSize()

71e9059

Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

grom72 force-pushed the grom72/DAOS-18495-ABT_THREAD_STACKSIZE-24k-md-on-ssd branch from 6992eb3 to 71e9059 Compare March 11, 2026 06:37

NiuYawei previously approved these changes Mar 11, 2026

View reviewed changes

NiuYawei requested a review from tanabarr March 11, 2026 06:56

Fix test

5f117f8

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2

grom72 dismissed NiuYawei’s stale review via 5f117f8 March 11, 2026 08:21

Final implementation

b0a85f7

Final implementation based on HasBdevRoleMeta(). Tests improvements. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2 Allow-unstable-test: true

grom72 requested a review from NiuYawei March 11, 2026 11:42

NiuYawei previously approved these changes Mar 11, 2026

View reviewed changes

tanabarr reviewed Mar 11, 2026

View reviewed changes

tanabarr previously approved these changes Mar 11, 2026

View reviewed changes

grom72 dismissed stale reviews from tanabarr and NiuYawei via 94a2f4f March 11, 2026 13:35

grom72 requested review from NiuYawei and tanabarr March 11, 2026 13:36

Trigger full validation

9265e2c

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2 Allow-unstable-test: true

grom72 marked this pull request as ready for review March 12, 2026 07:36

grom72 requested review from a team as code owners March 12, 2026 07:36

tanabarr previously approved these changes Mar 12, 2026

View reviewed changes

NiuYawei previously approved these changes Mar 12, 2026

View reviewed changes

grom72 requested review from a team as code owners March 16, 2026 07:47

Reapply "Merge remote-tracking branch 'origin/master' into grom72/DAO…

9c59cc1

…S-18495-ABT_THREAD_STACKSIZE-24k-md-on-ssd" This reverts commit d5bc34e. Priority: 2 Allow-unstable-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

grom72 requested review from NiuYawei, kjacque and tanabarr March 16, 2026 12:40

tanabarr approved these changes Mar 16, 2026

View reviewed changes

kjacque approved these changes Mar 16, 2026

View reviewed changes

grom72 requested a review from a team March 17, 2026 13:35

grom72 self-assigned this Mar 18, 2026

daltonbohning removed request for a team March 18, 2026 13:55

NiuYawei approved these changes Mar 19, 2026

View reviewed changes

grom72 requested a review from a team March 19, 2026 09:11

daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Mar 19, 2026

daltonbohning merged commit 6bdb8f9 into master Mar 19, 2026
32 checks passed

daltonbohning deleted the grom72/DAOS-18495-ABT_THREAD_STACKSIZE-24k-md-on-ssd branch March 19, 2026 16:18

Conversation

grom72 commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps for the author:

After all prior steps are complete:

Uh oh!

github-actions bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daosbuild3 commented Mar 11, 2026

Uh oh!

daosbuild3 commented Mar 11, 2026

Uh oh!

daosbuild3 commented Mar 11, 2026

Uh oh!

tanabarr Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

tanabarr Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

grom72 Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

tanabarr left a comment

Choose a reason for hiding this comment

Uh oh!

tanabarr Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

grom72 Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

tanabarr Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

grom72 Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

tanabarr left a comment

Choose a reason for hiding this comment

Uh oh!

daltonbohning commented Mar 18, 2026

Uh oh!

grom72 commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

grom72 commented Mar 11, 2026 •

edited

Loading

github-actions bot commented Mar 11, 2026 •

edited

Loading

grom72 commented Mar 19, 2026 •

edited

Loading