Skip to content

DAOS-18697 dfs: Improve error handling and memory management#17727

Merged
mchaarawi merged 1 commit intomasterfrom
mschaara/dfs_random_fixes
Mar 26, 2026
Merged

DAOS-18697 dfs: Improve error handling and memory management#17727
mchaarawi merged 1 commit intomasterfrom
mschaara/dfs_random_fixes

Conversation

@mchaarawi
Copy link
Copy Markdown
Contributor

@mchaarawi mchaarawi commented Mar 18, 2026

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026 •
edited
Loading

Ticket title is 'DFS code bug check'
Status is 'Open'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-18697

@mchaarawi mchaarawi changed the title DAOS-18697 DFS: Improve error handling and memory management DAOS-18697 dfs: Improve error handling and memory management Mar 18, 2026
@mchaarawi mchaarawi force-pushed the mschaara/dfs_random_fixes branch 2 times, most recently from 95e15df to 2910711 Compare March 18, 2026 23:21
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Mar 19, 2026

Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17727/3/testReport/

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Mar 20, 2026

Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17727/4/testReport/

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Mar 20, 2026

Test stage Functional Hardware Large MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17727/4/testReport/

@mchaarawi
DAOS-18697 DFS: Improve error handling and memory management
483d8ee 
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
@mchaarawi mchaarawi force-pushed the mschaara/dfs_random_fixes branch from 2910711 to 483d8ee Compare March 23, 2026 13:45
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Mar 24, 2026

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17727/6/execution/node/1040/log

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Mar 24, 2026

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17727/6/execution/node/1358/log

@mchaarawi
Copy link
Copy Markdown
Contributor Author

mchaarawi commented Mar 24, 2026

the full test was here:
https://jenkins-3.daos.hpc.amslabs.hpecorp.net/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-17727/6/pipeline
the daos build over dfuse timeout are known issues over VMs.
the stacktraces from the dm test looks to be related to dfuse being unmounted before the test finishes. test was repeated here 5x and it passed:
https://jenkins-3.daos.hpc.amslabs.hpecorp.net/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-17727/9/pipeline/

@mchaarawi mchaarawi marked this pull request as ready for review March 24, 2026 21:52
@mchaarawi mchaarawi requested review from a team as code owners March 24, 2026 21:52
knard38
knard38 reviewed Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM for what I understand.

knard38
knard38 reviewed Mar 25, 2026
View reviewed changes
knard38
knard38 approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mchaarawi mchaarawi requested review from a team and removed request for a team March 25, 2026 13:43
@mchaarawi
Copy link
Copy Markdown
Contributor Author

mchaarawi commented Mar 25, 2026

requested merge approval

@mchaarawi mchaarawi requested a review from a team March 26, 2026 12:44
@mchaarawi mchaarawi merged commit b6fd4aa into master Mar 26, 2026
36 of 40 checks passed
@mchaarawi mchaarawi deleted the mschaara/dfs_random_fixes branch March 26, 2026 12:44
mchaarawi added a commit that referenced this pull request Mar 26, 2026
@mchaarawi
DAOS-18697 DFS: Improve error handling and memory management (#17727)
85e0920 
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@knard38 knard38 knard38 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mchaarawi @daosbuild3 @daltonbohning @knard38