DAOS-18683 dfuse: fixes to read and write paths#17882
Conversation
|
Ticket title is 'dfuse/daos_build.py:DaosBuild.test_dfuse_daos_build_wb - Failure to build over dfuse in mode writeback' |
|
Test stage Build on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17882/1/execution/node/277/log |
|
Test stage Build on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17882/1/execution/node/285/log |
|
Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17882/1/execution/node/293/log |
mchaarawi
force-pushed
the
mschaara/dfuse_io_fixes
branch
5 times, most recently
from
0248baa to
ce633e7
Compare
|
Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17882/9/execution/node/984/log |
mchaarawi
force-pushed
the
mschaara/dfuse_io_fixes
branch
from
ce633e7 to
bea3c22
Compare
|
Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17882/13/testReport/ |
|
Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17882/13/testReport/ |
mchaarawi
force-pushed
the
mschaara/dfuse_io_fixes
branch
from
bea3c22 to
2a0443e
Compare
|
Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17882/13/testReport/ |
|
Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17882/14/testReport/ |
|
Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17882/15/execution/node/438/log |
- pre-read fixes mostly to handle EOF guards or overflows - init buffer to 0 in case of mock_read - write fixes for error cases Features: dfuse Allow-unstable-test: true Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
mchaarawi
force-pushed
the
mschaara/dfuse_io_fixes
branch
from
2a0443e to
a97032c
Compare
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17882/15/display/redirect |
|
Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17882/16/testReport/ |
|
existing failure with dfuse Feature tests: https://daosio.atlassian.net/browse/DAOS-18231 |
knard38
left a comment
knard38
left a comment
There was a problem hiding this comment.
LGTM for what I understand.
| if (rc) | ||
| D_GOTO(err, rc); | ||
|
|
||
| if (dfs_flags & DFS_SET_ATTR_SIZE) { |
There was a problem hiding this comment.
My apologies for the probably stupid question, but I am not very familiar with this part of the code.
Do not understand why this code needs to be done after the call of dfs_osetattr()
There was a problem hiding this comment.
to guard against DFS call failing for any reason, to not have the local cache state for dfuse truncate mode as mismatching the backend.
There was a problem hiding this comment.
Arghhh, make complete sense. The same as you have done with dfs_write() in write.c.
Thanks for the explanation.
- pre-read fixes mostly to handle EOF guards or overflows - init buffer to 0 in case of mock_read - write fixes for error cases Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
4 participants
Feature: dfuse
Steps for the author:
After all prior steps are complete: