Skip to content

DAOS-18763 cq: revert githook change that removes (C)#17891

Merged
daltonbohning merged 2 commits intomasterfrom
dbohning/daos-18763
Apr 2, 2026
Merged

DAOS-18763 cq: revert githook change that removes (C)#17891
daltonbohning merged 2 commits intomasterfrom
dbohning/daos-18763

Conversation

@daltonbohning
Copy link
Copy Markdown
Contributor

Revert the githook change that removes (C) from copyrights because the (C) is okay and it is better to be consistent.

Doc-only: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Revert the githook change that removes (C) from copyrights
because the (C) is okay and it is better to be consistent.

Doc-only: true

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Ticket title is 'Revert githook that removes (C) from copyright headers'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-18763

@daltonbohning daltonbohning marked this pull request as ready for review April 2, 2026 19:47
@daltonbohning daltonbohning requested review from a team as code owners April 2, 2026 19:47
@daltonbohning daltonbohning marked this pull request as draft April 2, 2026 19:47
mchaarawi
mchaarawi previously approved these changes Apr 2, 2026
@mchaarawi mchaarawi requested a review from soumagne April 2, 2026 19:48
soumagne
soumagne previously approved these changes Apr 2, 2026
@daltonbohning
Copy link
Copy Markdown
Contributor Author

GHA copyright check is going to fail on some of these because some files had copyright headers modified by Google for example and I am not adding an updated HPE copyright for those since this is just a revert.

@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Apr 2, 2026
@daltonbohning daltonbohning self-assigned this Apr 2, 2026
@daltonbohning daltonbohning marked this pull request as ready for review April 2, 2026 19:53
Doc-only: true

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
@daltonbohning daltonbohning dismissed stale reviews from soumagne and mchaarawi via 7d3d81b April 2, 2026 19:59
@daltonbohning daltonbohning requested a review from a team April 2, 2026 19:59
@daltonbohning daltonbohning merged commit aadf5de into master Apr 2, 2026
21 of 23 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-18763 branch April 2, 2026 19:59
daltonbohning added a commit that referenced this pull request Apr 2, 2026
Revert the githook change that removes (C) from copyrights
because the (C) is okay and it is better to be consistent.

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
daltonbohning added a commit that referenced this pull request Apr 2, 2026
Revert the githook change that removes (C) from copyrights
because the (C) is okay and it is better to be consistent.

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Development

Successfully merging this pull request may close these issues.

3 participants