Skip to content

DAOS-18793 cq: fix commit pragma stop_on_match#18163

Merged
daltonbohning merged 1 commit into
masterfrom
dbohning/daos-18793-fix
May 4, 2026
Merged

DAOS-18793 cq: fix commit pragma stop_on_match#18163
daltonbohning merged 1 commit into
masterfrom
dbohning/daos-18793-fix

Conversation

@daltonbohning
Copy link
Copy Markdown
Contributor

@daltonbohning daltonbohning commented May 1, 2026

Do not default stop_on_match to False since the nested default will always override the higher-level value.

Doc-only: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@daltonbohning
DAOS-18793 cq: fix commit pragma stop_on_match
a0c76ba 
Do not default stop_on_match to False since the nested default will
always override the higher-level value.

Doc-only: true

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
@daltonbohning daltonbohning self-assigned this May 1, 2026
@daltonbohning daltonbohning marked this pull request as ready for review May 1, 2026 22:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Ticket title is 'ftest: add mapping for cmocka tests to ftest tags'
Status is 'Awaiting backport'
Labels: 'request_for_2.6.6,request_for_2.8'
https://daosio.atlassian.net/browse/DAOS-18793

@daltonbohning daltonbohning requested a review from a team May 4, 2026 14:36
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label May 4, 2026
@daltonbohning daltonbohning merged commit f9124ea into master May 4, 2026
37 of 40 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-18793-fix branch May 4, 2026 14:36
grom72 pushed a commit that referenced this pull request May 11, 2026
@daltonbohning @grom72
DAOS-18793 cq: fix commit pragma stop_on_match (#18163)
914ff57 
Do not default stop_on_match to False since the nested default will
always override the higher-level value.

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
@daltonbohning daltonbohning mentioned this pull request Jun 3, 2026
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shimizukko shimizukko shimizukko approved these changes

@phender phender phender approved these changes

Assignees

@daltonbohning daltonbohning

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daltonbohning @shimizukko @phender