Skip to content

DAOS-623 test: update FI ignore warnings#18332

Merged
mchaarawi merged 1 commit into
masterfrom
mschaara/fi-warn
May 25, 2026
Merged

DAOS-623 test: update FI ignore warnings#18332
mchaarawi merged 1 commit into
masterfrom
mschaara/fi-warn

Conversation

@mchaarawi
Copy link
Copy Markdown
Contributor

Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-func-test-vm: true
Skip-func-hw-test: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

daltonbohning
daltonbohning previously approved these changes May 22, 2026
@github-actions
Copy link
Copy Markdown

Ticket title is 'Generic ticket for minor code cleanup and improvement'
Status is 'Resolved'
Labels: 'request_for_2.6.5,request_for_2.6.6,request_for_2.8,scrubbed_2.6.5'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-623

@github-actions github-actions Bot added the priority Ticket has high priority (automatically managed) label May 22, 2026
@mchaarawi mchaarawi marked this pull request as ready for review May 22, 2026 19:57
@mchaarawi mchaarawi requested a review from phender May 22, 2026 19:57
frostedcmos
frostedcmos previously approved these changes May 23, 2026
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-func-test-vm: true
Skip-func-hw-test: true

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
Copy link
Copy Markdown
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we wait until #17953 lands to master?
I think we will stop getting false positive warnings once we move FI tests to a more stable environment.

@mchaarawi
Copy link
Copy Markdown
Contributor Author

Shall we wait until #17953 lands to master? I think we will stop getting false positive warnings once we move FI tests to a more stable environment.

I see those as tangential.. this is updating the existing warnings that need to be ignored bec of CI instability.
IMO you have to first prove that your change can resolve such issues. Once you do, we can just remove all of these ignore warnings and not just this one in this PR.
thus I do not see a reason why we should wait and see more failing PRs that require force landing.

@mchaarawi mchaarawi requested a review from a team May 25, 2026 21:09
@mchaarawi
Copy link
Copy Markdown
Contributor Author

PR has passed FI and NLT last 2 runs. force landing required since only FI test is changed

@mchaarawi mchaarawi merged commit bf051bd into master May 25, 2026
33 checks passed
@mchaarawi mchaarawi deleted the mschaara/fi-warn branch May 25, 2026 21:10
mchaarawi added a commit that referenced this pull request May 26, 2026
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority Ticket has high priority (automatically managed)

Development

Successfully merging this pull request may close these issues.

4 participants