Skip to content

DAOS-19035 test: Genericize Cgo suppressions#18408

Merged
gnailzenh merged 3 commits into
masterfrom
kjacque/cgo-suppressions
Jun 4, 2026
Merged

DAOS-19035 test: Genericize Cgo suppressions#18408
gnailzenh merged 3 commits into
masterfrom
kjacque/cgo-suppressions

Conversation

@kjacque
Copy link
Copy Markdown
Contributor

@kjacque kjacque commented Jun 2, 2026 •
edited by tanabarr
Loading

  • Update Cgo suppressions with wildcards for the hashes, which can change.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@kjacque
DAOS-19035 test: Genericize Cgo suppressions
28e913a 
- Update Cgo suppressions with wildcards for the hashes, which can
  change.

Signed-off-by: Kris Jacque <kris.jacque@hpe.com>
@kjacque kjacque requested review from a team, mjmac and tanabarr June 2, 2026 18:02
@kjacque kjacque self-assigned this Jun 2, 2026
@kjacque kjacque requested review from a team as code owners June 2, 2026 18:02
knard38
knard38 previously approved these changes Jun 2, 2026
View reviewed changes
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Jun 2, 2026

Test stage NLT completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18408/1/testReport/

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Ticket title is 'NLT - Valgrind Memcheck error detected'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-19035

@kjacque
Add another type of malloc suppression
9e4a2ff 
Signed-off-by: Kris Jacque <kris.jacque@hpe.com>
mjmac
mjmac previously approved these changes Jun 2, 2026
View reviewed changes
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Jun 2, 2026

Test stage NLT completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18408/2/testReport/

tanabarr
tanabarr previously approved these changes Jun 3, 2026
View reviewed changes
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Jun 3, 2026

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18408/3/testReport/

@kjacque
Genericize cgo malloc in unit test suppression file
4e0b93e 
Signed-off-by: Kris Jacque <kris.jacque@hpe.com>
@kjacque kjacque dismissed stale reviews from tanabarr and mjmac via 4e0b93e June 3, 2026 18:58
@kjacque
Copy link
Copy Markdown
Contributor Author

kjacque commented Jun 3, 2026

@frostedcmos pointed out that there was another hashed cgo function name in the suppression file used for unit tests, so I fixed it there as well.

@kjacque kjacque requested review from knard38, mjmac and tanabarr June 3, 2026 18:59
@phender
Copy link
Copy Markdown
Contributor

phender commented Jun 3, 2026

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18408/3/testReport/

Known issue https://daosio.atlassian.net/browse/DAOS-19005

@tanabarr
Copy link
Copy Markdown
Contributor

tanabarr commented Jun 4, 2026

https://jenkins.daos.hpc.amslabs.hpecorp.net/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-18408/4/pipeline passed NLT without failure and given this is the only stage it affects I'm requesting force landing to fix NLT @gnailzenh

@tanabarr tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 4, 2026
@tanabarr tanabarr requested a review from a team June 4, 2026 11:39
@gnailzenh gnailzenh merged commit ebd9e03 into master Jun 4, 2026
38 of 45 checks passed
@gnailzenh gnailzenh deleted the kjacque/cgo-suppressions branch June 4, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanabarr tanabarr tanabarr approved these changes

@soumagne soumagne soumagne approved these changes

@knard38 knard38 knard38 approved these changes

@mjmac mjmac Awaiting requested review from mjmac

Assignees

@kjacque kjacque

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kjacque @daosbuild3 @phender @tanabarr @mjmac @soumagne @knard38 @gnailzenh