DAOS-6440 vos: remove invalid DTX status check#4303
Conversation
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
The dtx_leader_begin() may generate DTX entry in DRAM before any real modification. The index for such DTX entry will not be set until all related modifications are done locally. If the DTX is aborted before that, the dtx_rec_release() that is triggered by DTX abort logic will hit assertaion when check the index of DTX entry, that is wrong, and should be removed. Signed-off-by: Fan Yong <fan.yong@intel.com>
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
|
daos_test -T failed for DAOS-6539. |
|
@Nasf-Fan I re-ran my test with the latest rpms from this PR and I am still seeing lots (10000's ) of DER_CSUM errrors with checksum enabled on the container and DER_NO_PERM (-1001) when checksum is disabled on the container. |
This patch only fixes the DTX assertion() in VOS, nothing related with the checksum error. We need other patch to resolve checksum related issue. |
|
@daos-stack/daos-gatekeeper , please help to land this patch. Thanks! |
6 participants
The dtx_leader_begin() may generate DTX entry in DRAM before any
real modification. The index for such DTX entry will not be set
until all related modifications are done locally. If the DTX is
aborted before that, the dtx_rec_release() that is triggered by
DTX abort logic will hit assertaion when check the index of DTX
entry, that is wrong, and should be removed.
Signed-off-by: Fan Yong fan.yong@intel.com