DAOS-8927 vos: Lock memory for VOS pools#7153
Conversation
jolivier23
requested review from
NiuYawei,
frostedcmos,
gnailzenh and
johannlombardi
Change CART envirable to turn on memory pinning globally with it off by default. Instead, lock each vos pool individually. Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
jolivier23
force-pushed
the
jvolivie/unpin
branch
from
28b0c03 to
2560a27
Compare
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
|
Test stage NLT completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-7153/2/execution/node/789/log |
Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
|
Test stage NLT completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-7153/3/execution/node/730/log |
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
|
Test stage Unit Test completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-7153/4/execution/node/680/log |
Allow-unstable-test: true Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
|
The NLT warning is one that would need a force landing. This patch adds a warning when the system isn't configured for memory pinning (e.g. places a limit on locked pages). |
|
Failure is DAOS-8901 |
|
Please backport to release/2.0 |
Change CART envirable to turn on memory pinning globally with it off by default. Instead, lock each vos pool individually. Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
Change CART envirable to turn on memory pinning globally with it off by default. Instead, lock each vos pool individually. mlock will fail if trying to lock memory to a page boundary and PMDK doesn't even map the whole space if there is leftover bits on a page. Just round up the size to the next page boundary. Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
Ref: #7153 Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
5 participants
Change CART envirable to turn on memory pinning globally
with it off by default. Instead, lock each vos pool
individually.
Signed-off-by: Jeff Olivier jeffrey.v.olivier@intel.com