Skip to content

DAOS-8981 dfuse: Allow setattr of uid/gid in dfuse if data is unchanged. (#7204)#7553

Merged
johannlombardi merged 1 commit intorelease/2.0from
dfuse-uid-setattr-2
Jan 3, 2022
Merged

DAOS-8981 dfuse: Allow setattr of uid/gid in dfuse if data is unchanged. (#7204)#7553
johannlombardi merged 1 commit intorelease/2.0from
dfuse-uid-setattr-2

Conversation

@ashleypittman
Copy link
Copy Markdown
Contributor

A lot of clients seem to do this, often with other metadata updates
in the same call, so if this happens allow the change, but do not
attempt to apply it.

Remove ctime setattr check, this often happens with any type of
caching enabled.

Signed-off-by: Ashley Pittman ashley.m.pittman@intel.com

…ed. (#7204)

A lot of clients seem to do this, often with other metadata updates
in the same call, so if this happens allow the change, but do not
attempt to apply it.

Remove ctime setattr check, this often happens with any type of
caching enabled.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
Copy link
Copy Markdown
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

utils/node_local_test.py:168:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:379:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:434:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:438:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:445:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:553:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:555:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:579:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:610:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:622:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:637:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:712:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:959:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:960:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1016:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1059:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1204:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1523:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1528:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1534:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1563:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1595:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1596:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1609:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1624:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1703:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1763:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1788:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1805:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1806:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1858:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1905:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:1953:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2069:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2181:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2215:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2302:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2303:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2326:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2327:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2433:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2523:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2525:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2658:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2687:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2710:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2743:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:2912:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:3046:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:3148:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:3181:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:3195:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:3465:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:3466:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations

utils/node_local_test.py:3595:
(pylint-too-many-branches) Too many branches (26/25)

@johannlombardi johannlombardi merged commit 83c69c0 into release/2.0 Jan 3, 2022
@johannlombardi johannlombardi deleted the dfuse-uid-setattr-2 branch January 3, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants