DAOS-9178 build: Build fails with oneapi MPI (#7548)#7766
Merged
johannlombardi merged 1 commit intorelease/2.0from Dec 28, 2021
Merged
DAOS-9178 build: Build fails with oneapi MPI (#7548)#7766johannlombardi merged 1 commit intorelease/2.0from
johannlombardi merged 1 commit intorelease/2.0from
Conversation
Add I_MPI_ROOT to list of variables to passthrough if set Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
daosbuild1
reviewed
Dec 24, 2021
Collaborator
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
site_scons/prereq_tools/base.py:313:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
site_scons/prereq_tools/base.py:470:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
site_scons/prereq_tools/base.py:63:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
johannlombardi
approved these changes
Dec 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add I_MPI_ROOT to list of variables to passthrough if set
Signed-off-by: Jeff Olivier jeffrey.v.olivier@intel.com