DAOS-9216 dtx: use helper ULT to send DTX RPC#7779
Merged
johannlombardi merged 1 commit intorelease/2.0from Dec 29, 2021
Merged
DAOS-9216 dtx: use helper ULT to send DTX RPC#7779johannlombardi merged 1 commit intorelease/2.0from
johannlombardi merged 1 commit intorelease/2.0from
Conversation
master-commit: 440d0e6 If the DTX touches a lot of targets, and if we use current main XS to classify the DTX entries and send out related RPCs, then it may cause the main SX to be held for relative long time as to have no chance to handle other request, such as the DTX RPC from other targets. That is the potential risk of dead lock (or RPC timeout) among the targets if most of them are busy with DTX commit/abort with lots of targets. This patch defines new threshold "DTX_RPC_HELPER_THD": if the targets to be handled for the DTX RPC exceeds (or may exceed) such threshold, we will create a helper ULT to handle that dedicatedly. Signed-off-by: Fan Yong <fan.yong@intel.com>
daosbuild1
reviewed
Dec 28, 2021
Collaborator
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
johannlombardi
approved these changes
Dec 28, 2021
liuxuezhao
approved these changes
Dec 29, 2021
daltonbohning
added a commit
that referenced
this pull request
Feb 1, 2022
This reverts commit 577d51c.
daltonbohning
added a commit
that referenced
this pull request
Feb 1, 2022
This reverts commit 577d51c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master-commit: 440d0e6
If the DTX touches a lot of targets, and if we use current main XS to
classify the DTX entries and send out related RPCs, then it may cause
the main SX to be held for relative long time as to have no chance to
handle other request, such as the DTX RPC from other targets. That is
the potential risk of dead lock (or RPC timeout) among the targets if
most of them are busy with DTX commit/abort with lots of targets.
This patch defines new threshold "DTX_RPC_HELPER_THD": if the targets
to be handled for the DTX RPC exceeds (or may exceed) such threshold,
we will create a helper ULT to handle that dedicatedly.
Signed-off-by: Fan Yong fan.yong@intel.com