Skip to content

COVERITY-CID-345299: fix nil dereference in instance_drpc.go#7897

Merged
mjmac merged 2 commits intomasterfrom
tanabarr/coverity-345299
Jan 18, 2022
Merged

COVERITY-CID-345299: fix nil dereference in instance_drpc.go#7897
mjmac merged 2 commits intomasterfrom
tanabarr/coverity-345299

Conversation

@tanabarr
Copy link
Copy Markdown
Contributor

Signed-off-by: Tom Nabarro tom.nabarro@intel.com

@tanabarr tanabarr self-assigned this Jan 14, 2022
@tanabarr tanabarr requested review from dpquigl, kjacque and mjmac January 14, 2022 17:46
Copy link
Copy Markdown
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link
Copy Markdown
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mjmac mjmac merged commit 259c4b6 into master Jan 18, 2022
@mjmac mjmac deleted the tanabarr/coverity-345299 branch January 18, 2022 15:02
tanabarr added a commit that referenced this pull request Jan 18, 2022
As EngineInstance.addBdevStats() may sometimes be called with a nil NvmeController,
change the error constructor to use the address in the SmdDevice parameter.

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
mjmac pushed a commit that referenced this pull request Jan 19, 2022
…7912)

As EngineInstance.addBdevStats() may sometimes be called with a nil NvmeController,
change the error constructor to use the address in the SmdDevice parameter.

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants