Skip to content

DAOSGCP-161 Fix setting the --region parameter#75

Merged
mark-olson merged 1 commit intodaos-stack:developfrom
agayardo:main
Mar 9, 2023
Merged

DAOSGCP-161 Fix setting the --region parameter#75
mark-olson merged 1 commit intodaos-stack:developfrom
agayardo:main

Conversation

@agayardo
Copy link
Copy Markdown
Contributor

@agayardo agayardo commented Mar 1, 2023

This fixes the following error while building an image:

$ ./build_daos_io500_images.sh -t all -i false -f -w projects/my-project/locations/us-central1/workerPools/build-pool-1
[INFO ] Building DAOS disk images for IO500

[INFO ] Temp directory for image building: /tmp/tmp.QZtFLQeShK
[INFO ] Building DAOS server image: daos-server-io500-centos-7
[INFO ] Building DAOS Image(s)
[INFO ] Packer will be using service account serviceAccount:805869098137@cloudbuild.gserviceaccount.com
[INFO ] Using build worker pool projects/my-project/locations/us-central1/workerPools/build-pool-1, region
[INFO ] Building server image
Creating temporary tarball archive of 12 file(s) totalling 38.5 KiB before compression.
Uploading tarball of [.] to [gs://my-project_cloudbuild/source/1677693367.658952-458724d827ce43e4a5c8ffbef94d79ef.tgz]
ERROR: (gcloud.builds.submit) Invalid value for [--region]: --region flag required when workerpool resource includes region substitution

This is because the region is parsed out as empty, which seems to be a regression introduced in the previous commit.

@mark-olson
Copy link
Copy Markdown
Contributor

Thank you @agayardo

I created a JIRA ticket for this issue.
https://daosio.atlassian.net/browse/DAOSGCP-161

We like to have a JIRA ticket for each commit.

Can you amend the commit message so that it begins with the ticket number DAOSGCP-161?

Also, can you change the PR so that it merges to the develop branch instead of main?

We always merge to develop first. When all changes are ready to be included in a release we merge to main and tag.

Thanks again!

@agayardo agayardo changed the base branch from main to develop March 9, 2023 20:35
@mark-olson mark-olson changed the title Fix setting the --region parameter DAOSGCP-161 Fix setting the --region parameter Mar 9, 2023
Copy link
Copy Markdown
Contributor

@mark-olson mark-olson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

mark-olson
mark-olson previously approved these changes Mar 9, 2023
Signed-off-by: Artem Gayardo <artemgm@google.com>
@mark-olson mark-olson merged commit e8d6f8f into daos-stack:develop Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants