DAOSGCP-161 Fix setting the --region parameter#75
Merged
mark-olson merged 1 commit intodaos-stack:developfrom Mar 9, 2023
Merged
DAOSGCP-161 Fix setting the --region parameter#75mark-olson merged 1 commit intodaos-stack:developfrom
mark-olson merged 1 commit intodaos-stack:developfrom
Conversation
Contributor
|
Thank you @agayardo I created a JIRA ticket for this issue. We like to have a JIRA ticket for each commit. Can you amend the commit message so that it begins with the ticket number DAOSGCP-161? Also, can you change the PR so that it merges to the We always merge to Thanks again! |
mark-olson
reviewed
Mar 9, 2023
Contributor
mark-olson
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
mark-olson
previously approved these changes
Mar 9, 2023
Signed-off-by: Artem Gayardo <artemgm@google.com>
mark-olson
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following error while building an image:
This is because the region is parsed out as empty, which seems to be a regression introduced in the previous commit.