DAOSGCP-151 Remove MIGs in Terraform modules#77
Merged
mark-olson merged 1 commit intodaos-stack:developfrom Apr 27, 2023
mark-olson:DAOSGCP-151-2
Merged
DAOSGCP-151 Remove MIGs in Terraform modules#77mark-olson merged 1 commit intodaos-stack:developfrom mark-olson:DAOSGCP-151-2
mark-olson merged 1 commit intodaos-stack:developfrom
mark-olson:DAOSGCP-151-2
Conversation
Remove Managed Instance Group (MIG) provisioning from Terrform modules. For large deployments provisioning instances with google_compute_instance vs google_compute_instance_group_manager reduces provisioning time. This change was provided by Margaret Lawson. Signed-off-by: Margaret Lawson <mlawsonca@google.com> Signed-off-by: Mark Olson <115657904+mark-olson@users.noreply.github.com>
mlawsonca
approved these changes
Apr 27, 2023
Collaborator
mlawsonca
left a comment
mlawsonca
left a comment
There was a problem hiding this comment.
Everything looks great. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Managed Instance Group (MIG) provisioning from Terrform modules.
For large deployments provisioning instances with google_compute_instance vs google_compute_instance_group_manager reduces provisioning time.
This change was provided by Margaret Lawson.
Signed-off-by: Margaret Lawson mlawsonca@google.com
Signed-off-by: Mark Olson 115657904+mark-olson@users.noreply.github.com