Skip to content

Conversation

@osalyk
Copy link
Contributor

@osalyk osalyk commented Dec 17, 2025

No description provided.

Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
@osalyk osalyk force-pushed the osalyk/test_SRE-3459 branch from fea0e2d to 279da37 Compare January 12, 2026 13:41
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
@osalyk osalyk force-pushed the osalyk/test_SRE-3459 branch from 279da37 to fbae68f Compare January 23, 2026 10:01
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
@osalyk osalyk changed the title add image_version and modify target_stash SRE-3459: add image_version and modify target_stash Jan 23, 2026
@osalyk osalyk marked this pull request as ready for review January 23, 2026 12:53
@osalyk osalyk requested review from janekmi and ryon-jensen January 23, 2026 12:53
ryon-jensen
ryon-jensen previously approved these changes Jan 23, 2026
Copy link
Contributor

@ryon-jensen ryon-jensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know groovy that well, but I think looks good to me ... might just want to get rid of the printlns

JohnMalmberg
JohnMalmberg previously approved these changes Jan 23, 2026
Copy link
Collaborator

@JohnMalmberg JohnMalmberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to find a way to store this information in the DAOS repository. Pipeline Lib should not be containing mappings of releases to target versions.

Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
@osalyk osalyk dismissed stale reviews from JohnMalmberg and ryon-jensen via 8929bc9 January 26, 2026 11:29
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
ryon-jensen
ryon-jensen previously approved these changes Jan 26, 2026
@janekmi
Copy link

janekmi commented Jan 26, 2026

@janekmi
Copy link

janekmi commented Jan 26, 2026

Build release/2.6 on EL9.7

BuildRequired: ofi needs to be built, use --build-deps=yes:
  File "/builddir/build/BUILD/daos-2.6.4/SConstruct", line 504:
    scons()
  File "/builddir/build/BUILD/daos-2.6.4/SConstruct", line 443:
    prereqs.run_build(opts)
  File "/builddir/build/BUILD/daos-2.6.4/site_scons/prereq_tools/base.py", line 559:
    self.__env.Clone().require(comp)
  File "/usr/lib/python3.9/site-packages/SCons/Util/envs.py", line 242:
    return self.method(*nargs, **kwargs)
  File "/builddir/build/BUILD/daos-2.6.4/site_scons/prereq_tools/base.py", line 809:
    raise error
  File "/builddir/build/BUILD/daos-2.6.4/site_scons/prereq_tools/base.py", line 799:
    if comp_def.build(env, needed_libs):
  File "/builddir/build/BUILD/daos-2.6.4/site_scons/prereq_tools/base.py", line 1450:
    raise BuildRequired(self.name)

Ref: https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/ci-daos-stack-pipeline-lib-PR-488-release-2.6/27/artifact/artifacts/el9/build.log

Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
@osalyk osalyk requested a review from a team January 27, 2026 13:48
@JohnMalmberg
Copy link
Collaborator

Missing tests appear to be intentionally not run and not applicable to this PR.

@JohnMalmberg JohnMalmberg merged commit a3efbca into master Jan 27, 2026
5 checks passed
@JohnMalmberg JohnMalmberg deleted the osalyk/test_SRE-3459 branch January 27, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants