Skip to content

SRE-3534 ci: enable el9 functional tests#495

Merged
grom72 merged 2 commits intomasterfrom
grom72/SRE-3534-enable-el9-in-functional-tests
Mar 4, 2026
Merged

SRE-3534 ci: enable el9 functional tests#495
grom72 merged 2 commits intomasterfrom
grom72/SRE-3534-enable-el9-in-functional-tests

Conversation

@grom72
Copy link
Contributor

@grom72 grom72 commented Mar 3, 2026 •
edited
Loading

Until now the Functional tests stage on EL9 has been disabled if not explicitly enabled by pragmas in PR.
This behavior blocks possibility to switch to EL9 as default Functional tests' OS.

Tested by:
https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17632/4/pipeline-overview
(daos-stack/daos#17632)

@grom72
SRE-3534 ci: enable el9 functional tests
3aa8e26 
Until now the Functional tests stage on EL9 has been disabled in PRs if not
explicitly enabled by pragmas.
This behavior blocks the possibility to switch to EL9 as default Functional
tests' OS.

Priority: 2
Cancel-prev-build: false

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72 grom72 force-pushed the grom72/SRE-3534-enable-el9-in-functional-tests branch from 54258e7 to 3aa8e26 Compare March 3, 2026 13:35
@grom72 grom72 added forced-landing The PR has known failures or intentionally reduced testing, but should still be landed priority labels Mar 3, 2026
@grom72 grom72 mentioned this pull request Mar 3, 2026
Draft
7 tasks
osalyk
osalyk previously approved these changes Mar 3, 2026
View reviewed changes
@daltonbohning daltonbohning requested a review from phender March 3, 2026 15:02
@grom72
Copy link
Contributor Author

grom72 commented Mar 3, 2026

Solution has been tested here:
https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17632/4/pipeline-overview
and it is confirmed that el9 Functional tests can be triggered from PR without any pragmas forcing them.

phender
phender reviewed Mar 3, 2026
View reviewed changes
vars/skipStage.groovy Outdated
prRepos(distro) == '') ||
/* groovylint-disable-next-line UnnecessaryGetter */
(isPr() && !(distro in ['el8']))
(isPr() && !(distro in ['el8','el9']))
Copy link
Contributor

@phender phender Mar 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably just remove the entire line. The master and release/2.6 branches have CI_FUNCTIONAL_*_TEST params to determine if the Functional VM stage is run.

Copy link
Contributor

@phender phender Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an added bonus, not calling isPr() will remove the need to set CI_MORE_FUNCTIONAL_PR_TESTS to manually run additional Functional VM stages.

@grom72
Do not make any restriction on Functional tests in PRs
da9fb9c 
The default configuration of Functional test stages shall be defined by the parameters in Jenkins file.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72 grom72 requested review from osalyk and phender March 3, 2026 16:29
@phender
Copy link
Contributor

phender commented Mar 3, 2026

The release/2.6 downstream testing https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/ci-daos-stack-pipeline-lib-PR-495-release-2.6/3/pipeline-overview/?selected-node=1128 actually passed, although it ran all the Functional VM stages due to all the VM stages being selected by the params - not a particularly good test of this change.

The master downstream testing https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/ci-daos-stack-pipeline-lib-PR-495-master/3/pipeline-overview/ ran into github access problems. I've restarted it from the Test stages: https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/ci-daos-stack-pipeline-lib-PR-495-master/4/pipeline-overview/

@grom72
Copy link
Contributor Author

grom72 commented Mar 3, 2026

The release/2.6 downstream testing https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/ci-daos-stack-pipeline-lib-PR-495-release-2.6/3/pipeline-overview/?selected-node=1128 actually passed, although it ran all the Functional VM stages due to all the VM stages being selected by the params - not a particularly good test of this change.

The master downstream testing https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/ci-daos-stack-pipeline-lib-PR-495-master/3/pipeline-overview/ ran into github access problems. I've restarted it from the Test stages: https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/ci-daos-stack-pipeline-lib-PR-495-master/4/pipeline-overview/

Dedicated build with new default parameters:
https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17632/7/pipeline-overview/

        booleanParam(name: 'CI_FUNCTIONAL_el8_TEST',
                     defaultValue: false,
                     description: 'Run the Functional on EL 8 test stage')
        booleanParam(name: 'CI_FUNCTIONAL_el9_TEST',
                     defaultValue: true,
                     description: 'Run the Functional on EL 9 test stage')
        booleanParam(name: 'CI_FUNCTIONAL_leap15_TEST',
                     defaultValue: false,
                     description: 'Run the Functional on Leap 15 test stage' +
                                  '  Requires CI_MORE_FUNCTIONAL_PR_TESTS')

@grom72 grom72 merged commit b2d930a into master Mar 4, 2026
4 of 5 checks passed
@grom72 grom72 deleted the grom72/SRE-3534-enable-el9-in-functional-tests branch March 4, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janekmi janekmi janekmi approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@phender phender phender approved these changes

@osalyk osalyk Awaiting requested review from osalyk

Assignees

No one assigned

Labels

forced-landing The PR has known failures or intentionally reduced testing, but should still be landed priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@grom72 @phender @janekmi @daltonbohning @osalyk