Add ArcUpgradeScheme #718
Merged
Add ArcUpgradeScheme #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
suggested changes
Mar 18, 2020
orenyodfat
reviewed
Mar 19, 2020
orenyodfat
reviewed
Mar 19, 2020
orenyodfat
reviewed
Mar 19, 2020
| await helpers.registrationAddVersionToPackege(registration,[0, 1, 1]); | ||
| let contractsNames = []; | ||
| let contractsToUpgrade = []; | ||
| for (let i = 0; i < 21; i++) { |
There was a problem hiding this comment.
how about make it 60 ? like in the contract limit
There was a problem hiding this comment.
the loop adds 3 at a time
orenyodfat
reviewed
Mar 19, 2020
contracts/schemes/UpgradeScheme.sol
Outdated
Comment on lines
90
to
91
| require(proposal.exist, "must be a live proposal"); | ||
| require(proposal.passed == false, "cannot execute twice"); |
There was a problem hiding this comment.
Exists I think yes, but I removed the passed property
orenyodfat
reviewed
Mar 19, 2020
orenyodfat
reviewed
Mar 19, 2020
orenyodfat
reviewed
Mar 19, 2020
|
Amazing! 👏 😍 |
orenyodfat
reviewed
Mar 20, 2020
| require(proposal.exist, "must be a live proposal"); | ||
|
|
||
| if (_decision == 1) { | ||
| proposal.exist = false; |
There was a problem hiding this comment.
so this is another protection ..along with onlyVotingMachine .. let it be :)
orenyodfat
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.