Remove use of package keyword #720
Conversation
ben-kaufman
changed the title
contracts/schemes/UpgradeScheme.sol
Outdated
| address indexed _avatar, | ||
| bytes32 indexed _proposalId | ||
| bytes32 indexed _proposalId, | ||
| int256 _param |
There was a problem hiding this comment.
why is this needed ?
should it be a boolean ?
should it be called _decision ?
There was a problem hiding this comment.
It makes things slightly easier in the subgraph and we have it in all other contracts like that.
There was a problem hiding this comment.
should it be a boolean ?
should it be called _decision ?
There was a problem hiding this comment.
Not sure, it's an int everywhere else, I think the voting machine returns int so that's why.
There was a problem hiding this comment.
this are due to history reasons , we now have the chance to rewrite history :)
I think it should be boolean , name decision .
does subgraph look for this event ? why ?
There was a problem hiding this comment.
to mark the proposal as executed and in this case also update the contract info versions.
No description provided.