Skip to content

Update icon.md #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpetkov-sw merged 3 commits into from
Aug 26, 2020
Merged

Update icon.md #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
374318a
Update icon.md
lmcmz Aug 26, 2020
73d0f1d
Update image path
lmcmz Aug 26, 2020
86020c2
Fix markdown
lmcmz Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/codepush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@

The default behaviour will upload it in Staging env

![code](./Asset/code_push_1.png)
![code](./asset/code_push_1.png)

6. Move staging to production

![code2](./Asset/code_push_2.png)
![code2](./asset/code_push_2.png)
12 changes: 6 additions & 6 deletions doc/icon.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Icon configuration

For common, we are using **[iconfont.cn](https://www.iconfont.cn/) ** to manage icon and **[react-native-iconfont-cli](https://github.com/iconfont-cli/react-native-iconfont-cli)** to generate icon.
For common, we are using **[iconfont.cn](https://www.iconfont.cn/)** to manage icon and **[react-native-iconfont-cli](https://github.com/iconfont-cli/react-native-iconfont-cli)** to generate icon.

The full icon set locate in my project in iconfont, the js link represent everything.

![place](./Asset/icon_doc_1.png)
![place](./asset/icon_doc_1.png)

## Add or update new icon

Expand All @@ -14,19 +14,19 @@ Js link need to be regenerate everytime when the new icon is added or updated.

You can upload new icons using following button.

![icon_doc_2](./Asset/icon_doc_3.png)
![icon_doc_2](./asset/icon_doc_3.png)

#### 2. Regenerate new link

Once the icon set have been changed or updated, it will have a warning text above current js link, it will ask to regenerate new JS link after you click it.

![icon_doc](./Asset/icon_doc_4.png)
![icon_doc](./asset/icon_doc_4.png)

#### 3. Updated local link

Then you will need update local js link which locate in `./iconfont.js`.

![icon_doc_3](./Asset/icon_doc_2.png)
![icon_doc_3](./asset/icon_doc_2.png)

#### 4. Regenerate the icons

Expand All @@ -36,4 +36,4 @@ There is command to regenerate the icon
yarn icon
```

![icon_doc](./Asset/icon_doc_5.png)
![icon_doc](./asset/icon_doc_5.png)