Skip to content

Conversation

@MysticRyuujin
Copy link

@MysticRyuujin MysticRyuujin commented Feb 15, 2022

The following PR has the following changes / suggestions.

  • Move WebSocket port to 8545 - Geth has supported this for a while and it's easier to just expose a single port
  • Enable graphql by default - It doesn't hurt to turn it on, and having it on make life easier for developers
  • Include ws.api flags by default along with the http.api flags under EXTRA_OPTIONS
  • Changes type from library to service which I think is appropriate based on the description of type from here: https://docs.dappnode.io/developers/manifest-reference
  • Adds keywords to the dappnode_package.json
  • Removes the 30304/udp mapping - this port is no longer used by Geth
  • Replace the avatar with the actual / official go-ethereum mascot

Also new geth version v1.10.16

Feel free to cherry pick from this, I think these are all reasonable / appropriate but I also might not have the full context

@tropicar
Copy link

First of all, very thanks for all these suggestions. We will apply some of the changes you have proposed:

  • Changes type from library to service which I think is appropriate based on the description of type from here: https://docs.dappnode.io/developers/manifest-reference
  • Adds keywords to the dappnode_package.json
  • Removes the 30304/udp mapping - this port is no longer used by Geth

We think we would not enable the graphql by default.
These changes will be applied for the next update of the package

tropicar added a commit that referenced this pull request Feb 25, 2022
These changes were suggested by #36
tropicar and others added 2 commits March 2, 2022 11:42
We think if an user what to add this features , the user has to add them using extra_opts env
@tropicar tropicar merged commit ff36d0c into dappnode:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants