Merged
Conversation
Contributor
|
Great work! |
pablomendezroyo
approved these changes
May 16, 2023
pablomendezroyo
approved these changes
May 16, 2023
pablomendezroyo
approved these changes
May 16, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since toolkit needs to be implemented in this SDK and uses ethers.js version 6.3.0, updating ethers from 5.X.X to 6.X.X on the SDK was necessary. These changes do not introduce any new functionalities or alter the code's logic; they simply update the ethers.js calls within the code.
At the time of writing this, the ethers.js v6 documentation is far from finished, so some updated calls lack proper documentation, but I have successfully initialized and published a DappNode package using this version of the SDK, and all tests have passed.