Skip to content

Bump js-yaml to 4.1.0#402

Merged
dappnodedev merged 1 commit intomasterfrom
dappnodedev/bump-js-yaml-version
Mar 12, 2024
Merged

Bump js-yaml to 4.1.0#402
dappnodedev merged 1 commit intomasterfrom
dappnodedev/bump-js-yaml-version

Conversation

@dappnodedev
Copy link
Copy Markdown
Contributor

@dappnodedev dappnodedev commented Mar 11, 2024

Bump js-yaml to 4.1.0 as this latest library version makes yaml.load(...) function safe by default, so that safeLoad is no longer needed

@dappnodedev dappnodedev requested a review from a team as a code owner March 11, 2024 16:59
@dappnodedev dappnodedev merged commit 28cae58 into master Mar 12, 2024
@dappnodedev dappnodedev deleted the dappnodedev/bump-js-yaml-version branch March 12, 2024 11:15
dappnodedev added a commit that referenced this pull request Mar 12, 2024
@dappnodedev
Squashed commit of the following:
4c576eb 
commit 28cae58
Merge: dddaec8 ff912ae
Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
Date:   Tue Mar 12 12:15:35 2024 +0100

    Merge pull request #402 from dappnode/dappnodedev/bump-js-yaml-version

    Bump js-yaml to 4.1.0

commit ff912ae
Author: dappnodedev <diego@dappnode.io>
Date:   Mon Mar 11 17:58:03 2024 +0100

    Bump js-yaml to 4.1.0
dappnodedev added a commit that referenced this pull request Mar 12, 2024
@dappnodedev
Add template mode to build command (#398)
bdd21e9 
* Add build args for template mode and variants

* Merge manifest and compose files

* Build package variants

* Build all variants if none is defined

* Show DNP name on build

* Separate build dirs

* Fix build test

* Improve build handler style

* Perform modifications based on review

* Improve error handling in compose load

* Squashed commit of the following:

commit 28cae58
Merge: dddaec8 ff912ae
Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
Date:   Tue Mar 12 12:15:35 2024 +0100

    Merge pull request #402 from dappnode/dappnodedev/bump-js-yaml-version

    Bump js-yaml to 4.1.0

commit ff912ae
Author: dappnodedev <diego@dappnode.io>
Date:   Mon Mar 11 17:58:03 2024 +0100

    Bump js-yaml to 4.1.0

* Replace template flag by variants or all-variants

* Add templateMode flag to buildAndUpload

* Add templateMode flag to build call
dappnodedev added a commit that referenced this pull request Mar 13, 2024
@dappnodedev
Add template mode to build command (#398)
f56a1e6 
* Add build args for template mode and variants

* Merge manifest and compose files

* Build package variants

* Build all variants if none is defined

* Show DNP name on build

* Separate build dirs

* Fix build test

* Improve build handler style

* Perform modifications based on review

* Improve error handling in compose load

* Squashed commit of the following:

commit 28cae58
Merge: dddaec8 ff912ae
Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
Date:   Tue Mar 12 12:15:35 2024 +0100

    Merge pull request #402 from dappnode/dappnodedev/bump-js-yaml-version

    Bump js-yaml to 4.1.0

commit ff912ae
Author: dappnodedev <diego@dappnode.io>
Date:   Mon Mar 11 17:58:03 2024 +0100

    Bump js-yaml to 4.1.0

* Replace template flag by variants or all-variants

* Add templateMode flag to buildAndUpload

* Add templateMode flag to build call
dappnodedev added a commit that referenced this pull request Mar 13, 2024
@dappnodedev
Squashed commit of the following:
26d0432 
commit f56a1e6
Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
Date:   Tue Mar 12 14:48:10 2024 +0100

    Add template mode to build command (#398)

    * Add build args for template mode and variants

    * Merge manifest and compose files

    * Build package variants

    * Build all variants if none is defined

    * Show DNP name on build

    * Separate build dirs

    * Fix build test

    * Improve build handler style

    * Perform modifications based on review

    * Improve error handling in compose load

    * Squashed commit of the following:

    commit 28cae58
    Merge: dddaec8 ff912ae
    Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
    Date:   Tue Mar 12 12:15:35 2024 +0100

        Merge pull request #402 from dappnode/dappnodedev/bump-js-yaml-version

        Bump js-yaml to 4.1.0

    commit ff912ae
    Author: dappnodedev <diego@dappnode.io>
    Date:   Mon Mar 11 17:58:03 2024 +0100

        Bump js-yaml to 4.1.0

    * Replace template flag by variants or all-variants

    * Add templateMode flag to buildAndUpload

    * Add templateMode flag to build call

commit 28cae58
Merge: dddaec8 ff912ae
Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
Date:   Tue Mar 12 12:15:35 2024 +0100

    Merge pull request #402 from dappnode/dappnodedev/bump-js-yaml-version

    Bump js-yaml to 4.1.0

commit ff912ae
Author: dappnodedev <diego@dappnode.io>
Date:   Mon Mar 11 17:58:03 2024 +0100

    Bump js-yaml to 4.1.0
dappnodedev added a commit that referenced this pull request Mar 25, 2024
@dappnodedev
Squashed commit of the following:
ca2163c 
commit f3901de
Author: dappnodedev <diego@dappnode.io>
Date:   Thu Mar 21 17:08:59 2024 +0100

    Squashed commit of the following:

    commit 813907d
    Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
    Date:   Thu Mar 21 16:52:54 2024 +0100

        Refactor bump code (#407)

        * Refactor bump code

        * Check available ETH provider on first attempt

        * Improve git management

        * Fix pre-release handling

        * Fix bump tests

        * Rename valid release test

        * Fix import paths

        * Quick fixes after PR review

        * Create module github

        * Remove SDK build envs from file

        * Modularize bump settings

        * Add comment

        * Fix bump tests

        * Add ".js" to import paths

commit d50da2f
Merge: f56a1e6 64bcc60
Author: dappnodedev <diego@dappnode.io>
Date:   Wed Mar 13 20:58:14 2024 +0100

    Merge branch 'dappnodedev/add-template-mode-to-build' into dappnodedev/enable-templating

commit f56a1e6
Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
Date:   Tue Mar 12 14:48:10 2024 +0100

    Add template mode to build command (#398)

    * Add build args for template mode and variants

    * Merge manifest and compose files

    * Build package variants

    * Build all variants if none is defined

    * Show DNP name on build

    * Separate build dirs

    * Fix build test

    * Improve build handler style

    * Perform modifications based on review

    * Improve error handling in compose load

    * Squashed commit of the following:

    commit 28cae58
    Merge: dddaec8 ff912ae
    Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
    Date:   Tue Mar 12 12:15:35 2024 +0100

        Merge pull request #402 from dappnode/dappnodedev/bump-js-yaml-version

        Bump js-yaml to 4.1.0

    commit ff912ae
    Author: dappnodedev <diego@dappnode.io>
    Date:   Mon Mar 11 17:58:03 2024 +0100

        Bump js-yaml to 4.1.0

    * Replace template flag by variants or all-variants

    * Add templateMode flag to buildAndUpload

    * Add templateMode flag to build call

commit 28cae58
Merge: dddaec8 ff912ae
Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
Date:   Tue Mar 12 12:15:35 2024 +0100

    Merge pull request #402 from dappnode/dappnodedev/bump-js-yaml-version

    Bump js-yaml to 4.1.0

commit ff912ae
Author: dappnodedev <diego@dappnode.io>
Date:   Mon Mar 11 17:58:03 2024 +0100

    Bump js-yaml to 4.1.0
dappnodedev added a commit that referenced this pull request Mar 25, 2024
@dappnodedev
Add template flag to init command (#404)
c729a23 
* Add template option

* Create variants directories

* Add template mode to init command

* Squashed commit of the following:

commit f56a1e6
Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
Date:   Tue Mar 12 14:48:10 2024 +0100

    Add template mode to build command (#398)

    * Add build args for template mode and variants

    * Merge manifest and compose files

    * Build package variants

    * Build all variants if none is defined

    * Show DNP name on build

    * Separate build dirs

    * Fix build test

    * Improve build handler style

    * Perform modifications based on review

    * Improve error handling in compose load

    * Squashed commit of the following:

    commit 28cae58
    Merge: dddaec8 ff912ae
    Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
    Date:   Tue Mar 12 12:15:35 2024 +0100

        Merge pull request #402 from dappnode/dappnodedev/bump-js-yaml-version

        Bump js-yaml to 4.1.0

    commit ff912ae
    Author: dappnodedev <diego@dappnode.io>
    Date:   Mon Mar 11 17:58:03 2024 +0100

        Bump js-yaml to 4.1.0

    * Replace template flag by variants or all-variants

    * Add templateMode flag to buildAndUpload

    * Add templateMode flag to build call

commit 28cae58
Merge: dddaec8 ff912ae
Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
Date:   Tue Mar 12 12:15:35 2024 +0100

    Merge pull request #402 from dappnode/dappnodedev/bump-js-yaml-version

    Bump js-yaml to 4.1.0

commit ff912ae
Author: dappnodedev <diego@dappnode.io>
Date:   Mon Mar 11 17:58:03 2024 +0100

    Bump js-yaml to 4.1.0

* Update readManifest calls

* Allow using defaults for template mode

* Template build test

* Add writeVariantFiles

* Improve gitignore write

* Add defaults to flags

* Set default template values for testing

* Modularize init command

* Implement specific init tests

* Improve build tests

* Squashed commit of the following:

commit f3901de
Author: dappnodedev <diego@dappnode.io>
Date:   Thu Mar 21 17:08:59 2024 +0100

    Squashed commit of the following:

    commit 813907d
    Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
    Date:   Thu Mar 21 16:52:54 2024 +0100

        Refactor bump code (#407)

        * Refactor bump code

        * Check available ETH provider on first attempt

        * Improve git management

        * Fix pre-release handling

        * Fix bump tests

        * Rename valid release test

        * Fix import paths

        * Quick fixes after PR review

        * Create module github

        * Remove SDK build envs from file

        * Modularize bump settings

        * Add comment

        * Fix bump tests

        * Add ".js" to import paths

commit d50da2f
Merge: f56a1e6 64bcc60
Author: dappnodedev <diego@dappnode.io>
Date:   Wed Mar 13 20:58:14 2024 +0100

    Merge branch 'dappnodedev/add-template-mode-to-build' into dappnodedev/enable-templating

commit f56a1e6
Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
Date:   Tue Mar 12 14:48:10 2024 +0100

    Add template mode to build command (#398)

    * Add build args for template mode and variants

    * Merge manifest and compose files

    * Build package variants

    * Build all variants if none is defined

    * Show DNP name on build

    * Separate build dirs

    * Fix build test

    * Improve build handler style

    * Perform modifications based on review

    * Improve error handling in compose load

    * Squashed commit of the following:

    commit 28cae58
    Merge: dddaec8 ff912ae
    Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
    Date:   Tue Mar 12 12:15:35 2024 +0100

        Merge pull request #402 from dappnode/dappnodedev/bump-js-yaml-version

        Bump js-yaml to 4.1.0

    commit ff912ae
    Author: dappnodedev <diego@dappnode.io>
    Date:   Mon Mar 11 17:58:03 2024 +0100

        Bump js-yaml to 4.1.0

    * Replace template flag by variants or all-variants

    * Add templateMode flag to buildAndUpload

    * Add templateMode flag to build call

commit 28cae58
Merge: dddaec8 ff912ae
Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com>
Date:   Tue Mar 12 12:15:35 2024 +0100

    Merge pull request #402 from dappnode/dappnodedev/bump-js-yaml-version

    Bump js-yaml to 4.1.0

commit ff912ae
Author: dappnodedev <diego@dappnode.io>
Date:   Mon Mar 11 17:58:03 2024 +0100

    Bump js-yaml to 4.1.0

* Fix bump imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Marketen Marketen Marketen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dappnodedev @Marketen