-
Notifications
You must be signed in to change notification settings - Fork 29
Write manifest multi upstream #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: a6a6a4d This is a development version and should only be installed for testing purposes, install link (by dappnodebot/build-action) |
pablomendezroyo
requested changes
Apr 24, 2024
src/commands/githubActions/bumpUpstream/github/fetchGithubUpstreamVersion.ts
Show resolved
Hide resolved
pablomendezroyo
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After implementing #416 we need to merge this in order to modify the manifest properly in the bump action. This PR depends on dappnode/DNP_DAPPMANAGER#1936 to be merged and schemas and types be published after that. Also, those versions need to be bumped here.
The old way of handling multi-upstream repos like
"upstreamVersion": ["0.1.0", "0.1.2"]has been deprecated. Any package that has several upstream repos must define their versions and args like: