-
Notifications
You must be signed in to change notification settings - Fork 29
Improve publish code #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Improve publish code #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 0cda262 Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Thu May 2 10:28:27 2024 +0200 Update package.json version (#425) commit fffab38 Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Thu May 2 10:17:57 2024 +0200 Latest SDK published version i 0.3.20 (#424) commit e03ab72 Author: dappnodedev <diego@dappnode.io> Date: Thu May 2 10:03:18 2024 +0200 0.3.24 commit 8bb2b6e Author: dappnodedev <diego@dappnode.io> Date: Thu May 2 09:59:45 2024 +0200 0.3.23 commit e80c9ab Author: dappnodedev <diego@dappnode.io> Date: Thu May 2 09:38:59 2024 +0200 0.3.22 commit 9f70ac9 Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Thu May 2 09:38:03 2024 +0200 Fix create-release action (#423) commit cec9c30 Author: dappnodedev <diego@dappnode.io> Date: Thu May 2 09:24:21 2024 +0200 0.3.21 commit dcfbbab Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Thu May 2 09:23:46 2024 +0200 Bump @dappnode/schemas to 0.1.20 (#422)
commit bd7d9bb Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Wed May 8 12:24:16 2024 +0200 Enable build for variants (#421) * Reorganize init * Add init tests * Fix end to end test import * Reorganize init command * Avoid undefined in console log * Enable build for variants * Reorganize build command * Add variant alias to flag * Comment versions for all variants in build action * Enable build and comment for bump action in multi variants * Remove unused file * Add TODO comments * Avoid error on invalid variants * Add package variant to context * Add test for multi-variant package repo * Throw error on invalid variants * Add aliases to flags * Add alias to compose file name * Rename getImagePath * Improve parse archs function * Bump schemas version to 0.1.20 * Extract print results function * Simplify build handler * Reorganize buildAndUpload task * Split build tasks into several files * Improve connection verification * Improve file validation task * Improve file copy task * Fix tests * Update comment * Run prettier * Fix compose validation * Fix docker image build * read undefined number of files (compose and manifest) * Fix read manifest calls * Add temporary compose to gitignore * Improve validation * Rename writeBuildCompose to writeTmpCompose * Save releases.json for each variant * Squashed commit of the following: commit 0cda262 Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Thu May 2 10:28:27 2024 +0200 Update package.json version (#425) commit fffab38 Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Thu May 2 10:17:57 2024 +0200 Latest SDK published version i 0.3.20 (#424) commit e03ab72 Author: dappnodedev <diego@dappnode.io> Date: Thu May 2 10:03:18 2024 +0200 0.3.24 commit 8bb2b6e Author: dappnodedev <diego@dappnode.io> Date: Thu May 2 09:59:45 2024 +0200 0.3.23 commit e80c9ab Author: dappnodedev <diego@dappnode.io> Date: Thu May 2 09:38:59 2024 +0200 0.3.22 commit 9f70ac9 Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Thu May 2 09:38:03 2024 +0200 Fix create-release action (#423) commit cec9c30 Author: dappnodedev <diego@dappnode.io> Date: Thu May 2 09:24:21 2024 +0200 0.3.21 commit dcfbbab Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Thu May 2 09:23:46 2024 +0200 Bump @dappnode/schemas to 0.1.20 (#422) * Improve build tasks * Update chai version * Run all tests * Fix build tests * Add skip condition to save task * Fix publish tests * Fix publish tasks * Fix variant manifest path * Make skip upload and save independent * Skip upload results * Rename function to getValidVariantNames * Update read files description * Rename defaultVariantsDir to ...DirName * Move writeTmpCompose to specific file * More testing for variant build
Contributor
Author
|
Overridden by #428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring publish code in order to improve maintainability and to prepare the implementation of multi-variant packages in publish command