Enable variants on github action build#437
Merged
dappnodedev merged 1 commit intomasterfrom Jul 11, 2024
Merged
Conversation
dappnodedev
changed the title
pablomendezroyo
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github Action build was omitting flags
variantsandall-variants, so it would not build multi-variant packages. This PR enables itFurthermore, this PR aims to solve an existing issue, explained below:
Bot comment after github action build did not include the built hash, as shown here: dappnode/DNP_HTTPS#94 (comment)