Run: pass missing env variables#860
Conversation
- In the past, I openned this PR: dapr#770 - DCO had some complaints. - I incorrectly rebased. - This PR is made by forking the master branch, modifying related files Signed-off-by: Andy Le <anhldbk@gmail.com>
e596e52 to
0a6bd76
Compare
Codecov Report
@@ Coverage Diff @@
## master #860 +/- ##
==========================================
+ Coverage 22.32% 23.23% +0.91%
==========================================
Files 29 29
Lines 1550 1588 +38
==========================================
+ Hits 346 369 +23
- Misses 1163 1169 +6
- Partials 41 50 +9
Continue to review full report at Codecov.
|
|
@yaron2 PTAL |
|
LGTM overall. @mukundansundar can you please take one last look before we merge? |
|
@mukundansundar I wish this PR is merged on Jan 1st 2022. Would you pls make my dream come true? |
|
Overall looks good ... But my question still remains as to whether we need to expose these variables as ENV vars ... that too without DAPR prefix ... |
|
@mukundansundar Happy new year :) For your question, I already made a PR in our docs. Pls see |
|
@yaron2 @mukundansundar yay. You make my day. Thank you! |
|
@mukundansundar - Please prioritize this to get into 1.6 CLI release. |
- In the past, I openned this PR: dapr#770 - DCO had some complaints. - I incorrectly rebased. - This PR is made by forking the master branch, modifying related files Signed-off-by: Andy Le <anhldbk@gmail.com> Signed-off-by: imneov <grantliu@yunify.com>
Description
not-workingtutorialChecklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: