Skip to content

Conversation

@tianyax
Copy link
Contributor

@tianyax tianyax commented Mar 7, 2023

Description

Fixed the problem that the output of the dapr did not match the documentation after installation.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1254

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@tianyax tianyax requested review from a team as code owners March 7, 2023 13:26
@tianyax
Copy link
Contributor Author

tianyax commented Mar 7, 2023

local validation results:

image

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #1255 (814d6ec) into master (5e3546a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1255   +/-   ##
=======================================
  Coverage   27.27%   27.27%           
=======================================
  Files          38       38           
  Lines        3711     3711           
=======================================
  Hits         1012     1012           
  Misses       2633     2633           
  Partials       66       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@shubham1172 shubham1172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --version flag should be the same as dapr version IMO. It is meaningful to provide both CLI and installed runtime's version.

@tianyax
Copy link
Contributor Author

tianyax commented Mar 8, 2023

The --version flag should be the same as dapr version IMO. It is meaningful to provide both CLI and installed runtime's version.

@shubham1172 For --version flag I think in most cases it should print its own information, and it overlaps with the dapr version function, I respect the original design and will make a change.😊

Signed-off-by: tianya <tianyax@outlook.com>
Copy link
Collaborator

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukundansundar mukundansundar dismissed shubham1172’s stale review March 8, 2023 15:56

changes addressed.

@mukundansundar mukundansundar merged commit 72551c9 into dapr:master Mar 8, 2023
@mukundansundar
Copy link
Collaborator

@tianyax Thanks for the contribution, welcome to the Dapr community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

verify command doesn't output as expected in doc

3 participants