Skip to content

Add NATS ack policy docs #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2022
Merged

Add NATS ack policy docs #2992

merged 1 commit into from
Dec 14, 2022

Conversation

@Jarema
Copy link
Contributor

@Jarema Jarema commented Dec 5, 2022

Thank you for helping make the Dapr documentation better!

This adds docs for dapr/components-contrib#2340

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

@Jarema
Add ack policy docs
e9fe37c 
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema requested review from a team as code owners December 5, 2022 16:53
@Jarema Jarema changed the title Add ack policy docs Add NATS ack policy docs Dec 5, 2022
hhunter-ms
hhunter-ms approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

github-actions bot commented Dec 14, 2022

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 14, 2022
@msfussell msfussell merged commit 26e134f into dapr:v1.10 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hhunter-ms hhunter-ms hhunter-ms approved these changes

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jarema @hhunter-ms @msfussell